[MDL-27548] The comments table should contain the component - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 2.0.3
Fix Version/s: 2.9
Component/s: Comments
Labels:
- ci
- triaged

Affected Branches:
MOODLE_20_STABLE
Fixed Branches:
MOODLE_29_STABLE
Pull from Repository:
git://github.com/samhemelryk/moodle.git
Pull Master Branch:
27548-29
Pull Master Diff URL:
http://mdl.icodedthat.com/27548-29
Testing Instructions:
Hide

Test upgrade.

Before upgrade:

Log in as admin

Browse to a course and add a comments block.

Log in as a student

Make several comments.

After upgrade:

Log in as the student again

Browse back to the course.

Check that you comments are still shown there correctly.

Area testing.

Manually test (using a couple of users):

Assignment module submission comments and feedback comments

Comments block

Disable JavaScript and test test the comments block again

Blog entry comments

Comment on database entries (turn on Allow comments on entries)

Comment on glossary entries (turn on Allow comments on entries)

Comment on a wiki page.

After all your manual testing inspect the comments table in your database and check all of the comments you added have the component set.

Behat cover this area

Run behat tests on:

@block_comments

@core_blog

@mod_assign
Show
Test upgrade. Before upgrade: Log in as admin Browse to a course and add a comments block. Log in as a student Make several comments. After upgrade: Log in as the student again Browse back to the course. Check that you comments are still shown there correctly. Area testing. Manually test (using a couple of users): Assignment module submission comments and feedback comments Comments block Disable JavaScript and test test the comments block again Blog entry comments Comment on database entries (turn on Allow comments on entries) Comment on glossary entries (turn on Allow comments on entries) Comment on a wiki page. After all your manual testing inspect the comments table in your database and check all of the comments you added have the component set. Behat cover this area Run behat tests on: @block_comments @core_blog @mod_assign

Description

The component is now required within comments API however it is not presently being stored in the database.
This should really happen as ratings stores its component in the database and having it there ensure that comment objects are complete when loaded from the database and allows use to improve our SQL by selecting upon that as well.

Attachments

Issue Links

has a non-specific relationship to

MDL-27471 Add a ratingarea field to the ratings API

Closed

is duplicated by

MDL-37243 Comments API doesn't store or validate component

Closed

Activity

People

Assignee:: Sam Hemelryk

Reporter:: Sam Hemelryk

Peer reviewer:: Frédéric Massart

Integrator:: Dan Poltawski

Tester:: Frédéric Massart

Participants:: CiBoT, Dan Poltawski, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7), Frédéric Massart, Marina Glancy, Sam Hemelryk

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 18/May/11 10:12 PM

Updated:: 16/Oct/15 10:27 PM

Resolved:: 06/Dec/14 4:07 AM

Fix Release Date:: 11/May/15