Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27548

The comments table should contain the component

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.9
    • Component/s: Comments
    • Labels:
    • Testing Instructions:
      Hide

      Test upgrade.

      Before upgrade:

      1. Log in as admin
      2. Browse to a course and add a comments block.
      3. Log in as a student
      4. Make several comments.

      After upgrade:

      1. Log in as the student again
      2. Browse back to the course.
      3. Check that you comments are still shown there correctly.

      Area testing.

      Manually test (using a couple of users):

      • Assignment module submission comments and feedback comments
      • Comments block
      • Disable JavaScript and test test the comments block again
      • Blog entry comments
      • Comment on database entries (turn on Allow comments on entries)
      • Comment on glossary entries (turn on Allow comments on entries)
      • Comment on a wiki page.

      After all your manual testing inspect the comments table in your database and check all of the comments you added have the component set.

      Behat cover this area

      Run behat tests on:

      • @block_comments
      • @core_blog
      • @mod_assign
      Show
      Test upgrade. Before upgrade: Log in as admin Browse to a course and add a comments block. Log in as a student Make several comments. After upgrade: Log in as the student again Browse back to the course. Check that you comments are still shown there correctly. Area testing. Manually test (using a couple of users): Assignment module submission comments and feedback comments Comments block Disable JavaScript and test test the comments block again Blog entry comments Comment on database entries (turn on Allow comments on entries) Comment on glossary entries (turn on Allow comments on entries) Comment on a wiki page. After all your manual testing inspect the comments table in your database and check all of the comments you added have the component set. Behat cover this area Run behat tests on: @block_comments @core_blog @mod_assign
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      27548-29
    • Pull Master Diff URL:

      Description

      The component is now required within comments API however it is not presently being stored in the database.
      This should really happen as ratings stores its component in the database and having it there ensure that comment objects are complete when loaded from the database and allows use to improve our SQL by selecting upon that as well.

        Attachments

          Issue Links

          has a non-specific relationship to

          Improvement - An enhancement to an existing Moodle feature. MDL-27471 Add a ratingarea field to the ratings API

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          is duplicated by

          Improvement - An enhancement to an existing Moodle feature. MDL-37243 Comments API doesn't store or validate component

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              samhemelryk Sam Hemelryk
              Peer reviewer:
              Frédéric Massart Frédéric Massart
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Frédéric Massart Frédéric Massart
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15