Moodle
  1. Moodle
  2. MDL-27550

Teacher's feedback not available to students in the workshop module

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Workshop
    • Labels:
    • Testing Instructions:
      Hide

      1. Set up a workshop with at least one submission and one peer-assessment
      2. As a teacher, provide the feedback to the author of the submission and the feedback to the reviewer
      3. Close the workshop
      4. TEST: Make sure that the feedback for the author is available to them
      5. TEST: Make sure that the feedback for the reviewer is available to them

      Show
      1. Set up a workshop with at least one submission and one peer-assessment 2. As a teacher, provide the feedback to the author of the submission and the feedback to the reviewer 3. Close the workshop 4. TEST: Make sure that the feedback for the author is available to them 5. TEST: Make sure that the feedback for the reviewer is available to them
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27550-workshop-feedback
    • Rank:
      17253

      Description

      In workshop, the teacher can provide feedback for both submission and each assessment. However, as Jorge Villalon reported at http://moodle.org/mod/forum/discuss.php?d=166859#p769665 these feedbacks are not currently displayed to students. Well, the feedback on the submission is at least pushed into the gradebook. But the feedback on the assessment is not available at all.

      Both of them should be available to students within the workshop once the workshop is closed.

        Activity

        Hide
        David Mudrak added a comment -

        Attaching three screenshots that show

        • workshop main page in the closed phase for the student, showing teacher's feedback on the student's submission and one of their assessment
        • assessment page with the feedback
        • submission page with the feedback

        As you can see, the feedback is displayed just below the element it links to (the submission or the assessment). Screenshots also demonstrates other improvements made while working on this fix (collapsible assessment details etc)

        Show
        David Mudrak added a comment - Attaching three screenshots that show workshop main page in the closed phase for the student, showing teacher's feedback on the student's submission and one of their assessment assessment page with the feedback submission page with the feedback As you can see, the feedback is displayed just below the element it links to (the submission or the assessment). Screenshots also demonstrates other improvements made while working on this fix (collapsible assessment details etc)
        Hide
        Sam Hemelryk added a comment -

        Hi David,

        I've just been reading over this and playing with the workshop module. Only spotted one thing that needs to be tidied up mod_workshop_renderer::render_workshop_submission on occasion prints an h3 heading within a anchor breaking xhtml.

        I did notice something that looked irregular to me however with the grade given through a student assessment, although perhaps it is my lack of experience with the module.
        I'll describe it and if you could please let me know what you think:

        1. I created a new workshop in a course with 2 users A and B.
        2. The workshop had an assessment grade of 20
        3. I created 2 assessment aspects, the first worth a max of 7, the second worth a max of 3.
        4. User A assesses user B and gives 5/7 and 2/3. This shows a grade of 14/20 which looks correct.
        5. User B assesses user A and gives 4/7 and 1/3. This shows a grade of 9/20 which looks wrong. I would have though this would result in 10/20.

        Keen to see whether this is something I am misunderstanding or whether there is actually something going on here.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi David, I've just been reading over this and playing with the workshop module. Only spotted one thing that needs to be tidied up mod_workshop_renderer::render_workshop_submission on occasion prints an h3 heading within a anchor breaking xhtml. I did notice something that looked irregular to me however with the grade given through a student assessment, although perhaps it is my lack of experience with the module. I'll describe it and if you could please let me know what you think: I created a new workshop in a course with 2 users A and B. The workshop had an assessment grade of 20 I created 2 assessment aspects, the first worth a max of 7, the second worth a max of 3. User A assesses user B and gives 5/7 and 2/3. This shows a grade of 14/20 which looks correct. User B assesses user A and gives 4/7 and 1/3. This shows a grade of 9/20 which looks wrong. I would have though this would result in 10/20. Keen to see whether this is something I am misunderstanding or whether there is actually something going on here. Cheers Sam
        Hide
        David Mudrak added a comment -

        Thanks for the detailed peer-review Sam. I added another commit to the branches that fixes the XHTML strictness of H3 + A combo. Thanks for spotting it.

        Regarding the calculation of the final grade - the result you described is expected. In the accumulative grading strategy you used, the final grade 9/20 is calculated as follows:

        • User B assesses user A and gives 4/7 and 1/3
        • The grade 4/7 is normalized to 57% and the grade 1/3 is normalized to 33%
        • The final grade is the average or these two sub-grades - 45% leading to 9/20

        In other words, you can't sum the given grades and divide them by the maximum grades as you did with (4+1)/(7+3). The accumulative grading strategy does not weight the sub-grades according the number of the scale items. Both 3-point and 7-point scales have the same weight.

        Show
        David Mudrak added a comment - Thanks for the detailed peer-review Sam. I added another commit to the branches that fixes the XHTML strictness of H3 + A combo. Thanks for spotting it. Regarding the calculation of the final grade - the result you described is expected. In the accumulative grading strategy you used, the final grade 9/20 is calculated as follows: User B assesses user A and gives 4/7 and 1/3 The grade 4/7 is normalized to 57% and the grade 1/3 is normalized to 33% The final grade is the average or these two sub-grades - 45% leading to 9/20 In other words, you can't sum the given grades and divide them by the maximum grades as you did with (4+1)/(7+3). The accumulative grading strategy does not weight the sub-grades according the number of the scale items. Both 3-point and 7-point scales have the same weight.
        Hide
        David Mudrak added a comment -

        Submitting for integration after the detailed peer-review by Sam.

        Show
        David Mudrak added a comment - Submitting for integration after the detailed peer-review by Sam.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Rossiani Wijaya added a comment -

        Thanks for fixing the issue David

        Test passed

        Show
        Rossiani Wijaya added a comment - Thanks for fixing the issue David Test passed
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Sent upstream and closing, many thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Sent upstream and closing, many thanks!

          People

          • Votes:
            4 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: