Moodle
  1. Moodle
  2. MDL-27555

Assignment submissions page options make no sense for the offline assignment type.

    Details

    • Testing Instructions:
      Hide

      1. login as teacher
      2. select/create an offline assignment
      4. on the assignment page, click on 'View assignment grades and feedback' link (top right)
      5. within 'optional setting' section, available option should only contain 'all' and 'required grading'

      Note: If optional setting was set on 'submitted', it will reset the option to display all for offline assignment.

      Show
      1. login as teacher 2. select/create an offline assignment 4. on the assignment page, click on 'View assignment grades and feedback' link (top right) 5. within 'optional setting' section, available option should only contain 'all' and 'required grading' Note: If optional setting was set on 'submitted', it will reset the option to display all for offline assignment.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      17219

      Description

      During integration of MDL-27161 it was found that the strings shown to the user when they are viewing assignment submissions and select either require grading or submitted make no sense.
      In fact I don't think the submitted option makes any sense given as Helen pointed out we don't track submitted assignments for the offline type.

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Rosie could you please look at this seeing as you are familiar with that area now.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Rosie could you please look at this seeing as you are familiar with that area now. Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          Hi Rosie,
          I've had a quick look at this and it looks good to me.
          Please create a MOODLE_21_STABLE branch and put it up for integration.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Rosie, I've had a quick look at this and it looks good to me. Please create a MOODLE_21_STABLE branch and put it up for integration. Cheers Sam
          Hide
          Rossiani Wijaya added a comment -

          Thanks Sam.

          Added patch for M21 and submitting for integration.

          Show
          Rossiani Wijaya added a comment - Thanks Sam. Added patch for M21 and submitting for integration.
          Hide
          Sam Hemelryk added a comment -

          Thanks Rosie, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Rosie, this has been integrated now
          Hide
          Petr Škoda added a comment -

          Adding preferential treatment for some plugins should be a big 'nono', $assignment->assignmenttype == 'offline' prevents other 3rd party plugins to do the same. Right here this is not very important because we should not imo encourage custom assignment subplugins anyway.

          Show
          Petr Škoda added a comment - Adding preferential treatment for some plugins should be a big 'nono', $assignment->assignmenttype == 'offline' prevents other 3rd party plugins to do the same. Right here this is not very important because we should not imo encourage custom assignment subplugins anyway.
          Hide
          Petr Škoda added a comment -

          Tested, works as described.

          There is a slight remaining problem, the grading page shows empty "Submissions" box, I suppose this can be fixed in a separate issue.

          Thanks!

          Show
          Petr Škoda added a comment - Tested, works as described. There is a slight remaining problem, the grading page shows empty "Submissions" box, I suppose this can be fixed in a separate issue. Thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: