Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      Only dev can test it (web service experience recommended):

      Run the unit test for this function (webservice/simpletest => enable protocol, function and token)

      Show
      Only dev can test it (web service experience recommended): Run the unit test for this function (webservice/simpletest => enable protocol, function and token)
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull Master Branch:
      MDL-27564-wip

      Description

      username
      fullname
      profileimgurl (big version)

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            jerome Jérôme Mouneyrac added a comment -

            Optional: for later we will probably implement:

            • Roles of the user in this course
            • Group of the user in this course
            Show
            jerome Jérôme Mouneyrac added a comment - Optional: for later we will probably implement: Roles of the user in this course Group of the user in this course
            Hide
            dongsheng Dongsheng Cai added a comment -

            Jerome, two issues should be noted
            1. DISTINCT in SQL not working well on some dbms, probably should use sub query here
            2. the profile image url doesn't respect $CFG->slasharguments, we should make use the function to generate the profile url.

            Show
            dongsheng Dongsheng Cai added a comment - Jerome, two issues should be noted 1. DISTINCT in SQL not working well on some dbms, probably should use sub query here 2. the profile image url doesn't respect $CFG->slasharguments, we should make use the function to generate the profile url.
            Hide
            jerome Jérôme Mouneyrac added a comment -

            fixed

            Show
            jerome Jérôme Mouneyrac added a comment - fixed
            Hide
            jerome Jérôme Mouneyrac added a comment -

            fixed for Postgres (Group by must have all fields listed in the SELECT, or they must be used in HAVING CLOSE)

            Show
            jerome Jérôme Mouneyrac added a comment - fixed for Postgres (Group by must have all fields listed in the SELECT, or they must be used in HAVING CLOSE)
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Fixed up the pull information

            Show
            samhemelryk Sam Hemelryk added a comment - Fixed up the pull information
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Does this need a version bump anywhere or is it relying on the release version bump?

            Show
            samhemelryk Sam Hemelryk added a comment - Does this need a version bump anywhere or is it relying on the release version bump?
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Jerome as talked about this needs to be worked on further to get the user names fixed up.

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Jerome as talked about this needs to be worked on further to get the user names fixed up.
            Hide
            jerome Jérôme Mouneyrac added a comment -

            fixing username - and first/last name issue (note: no need to bump the version, only when services.php is edited it needs to be bumped)

            Show
            jerome Jérôme Mouneyrac added a comment - fixing username - and first/last name issue (note: no need to bump the version, only when services.php is edited it needs to be bumped)
            Hide
            jerome Jérôme Mouneyrac added a comment -

            fixed, rebased, no whitespaces, no need to bump the version, should be ok, cross finger

            Show
            jerome Jérôme Mouneyrac added a comment - fixed, rebased, no whitespaces, no need to bump the version, should be ok, cross finger
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Jerome this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Jerome this has been integrated now.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Passing based on tests

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Passing based on tests
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This is now upstream, yay! Many thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This is now upstream, yay! Many thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Jul/11