Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27594

XML start/end parsing modifications correct order on empty paths

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide
      • Enable DEBUG = developer
      • Run the unit tests (Admin -> Developer -> Unit tests) by specifying "backup/util/xml/parser".
      • TEST: All tests pass ok.
      • TEST: The number of tests is, at least, 248
      • TEST: Restore some 2.x course, it should finish as usual
      Show
      Enable DEBUG = developer Run the unit tests (Admin -> Developer -> Unit tests) by specifying "backup/util/xml/parser". TEST: All tests pass ok. TEST: The number of tests is, at least, 248 TEST: Restore some 2.x course, it should finish as usual
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      This is one followup of MDL-27475, where David discovered one real example of start/process/end notifications not happening in correct order under some circumstances (empty chunks).

      The fix changes completely the way start/end notifications were dispatched previously, by implementing one simple stack of pending notifications and dispatching them when necessary.

      The fix adds 2 new test cases covering the trouble-maker situation (exaggerated!), without modifying previous tests, so no change is expected in behavior at all (BC ok).

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    1/Jul/11