Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27625

Regression: cannot delete ratings

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.0.4
    • Component/s: Ratings
    • Database:
      Any
    • Testing Instructions:
      Hide

      Fix is 100% the same for 20_STABLE and master so should be enough to test under 20_STABLE:

      • Create two forums (one with numerical scale and another with custom scale) with some posts.
      • Create two datas (one with numerical scale and another with custom scale) with some records.
      • Create two glossaries (one with numerical scale and another with custom scale) with some entries.
      • Rate 1 post, one record and one entry (at least)
      • TEST: Try to unrate them with JS enabled. No error should happen.
      • TEST: Refresh the page. The unrated values continue unrated.
      • TEST: Try to unrate them with JS disable. No error should happen.
      • TEST: Refresh the page. The unrated values continue unrated.
      Show
      Fix is 100% the same for 20_STABLE and master so should be enough to test under 20_STABLE: Create two forums (one with numerical scale and another with custom scale) with some posts. Create two datas (one with numerical scale and another with custom scale) with some records. Create two glossaries (one with numerical scale and another with custom scale) with some entries. Rate 1 post, one record and one entry (at least) TEST: Try to unrate them with JS enabled. No error should happen. TEST: Refresh the page. The unrated values continue unrated. TEST: Try to unrate them with JS disable. No error should happen. TEST: Refresh the page. The unrated values continue unrated.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27625_master
    • Pull Master Diff URL:

      Description

      You don't seem to be able to delete a rating. If you select "Rate..." it should delete your rating. I'm getting an error back "Invalid numeric value"

      Its due to this code in the 3 per module rating validation functions.
      if ($params['rating'] < 0)

      { throw new rating_exception('invalidnum'); }

        Attachments

          Issue Links

          will help resolve

          Improvement - An enhancement to an existing Moodle feature. MDL-27471 Add a ratingarea field to the ratings API

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              andyjdavis Andrew Davis
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Helen Foster
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                1/Aug/11