Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27627

Form element without id name

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.1
    • Component/s: Activity completion
    • Labels:
    • Testing Instructions:
      Hide

      Difficulty: EASY (but requires some familiarity with html)

      0. Ensure that the site-level availability and completion options are enabled, and that a test course has completion enabled.
      1. From the 'Add a resource' dropdown, choose 'Label' so that you get the module editing form.
      2. By viewing source or using Firebug or similar extension, check that the two fieldsets 'Activity completion' and 'Restrict access' both now have ID values (they did not before).
      3. Type in some text for the label and save the form (there are supposed to be no changes to this, but just to check it's not broken).

      Show
      Difficulty: EASY (but requires some familiarity with html) 0. Ensure that the site-level availability and completion options are enabled, and that a test course has completion enabled. 1. From the 'Add a resource' dropdown, choose 'Label' so that you get the module editing form. 2. By viewing source or using Firebug or similar extension, check that the two fieldsets 'Activity completion' and 'Restrict access' both now have ID values (they did not before). 3. Type in some text for the label and save the form (there are supposed to be no changes to this, but just to check it's not broken).
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull Master Branch:
      MDL-27627-master

      Description

      There are few mform elements that are added without any id name, which means, if one wants to select it (to hide or remove or whatever) it is difficult.

      The example codes are: in "course->moodleform_mod.php"
      1) line 436, $mform->addElement('header', '', get_string('availabilityconditions', 'condition'));
      2) line 530, $mform->addElement('header', '', get_string('activitycompletion', 'completion'));

      They need some name names to be assigned. once that is done, possibly anyone using those elements referring with empty names also might need changing.

        Attachments

          Activity

            People

            Assignee:
            quen Sam Marshall
            Reporter:
            karlmarxr Karlmarx rajangam
            Integrator:
            Sam Hemelryk
            Tester:
            Michael de Raadt
            Participants:
            Component watchers:
            Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              1/Jul/11