Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-2763

Garbled characters in utf-8 env when popping up the insert link window for HTML editor

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Trivial
          • Resolution: Fixed
          • Affects Version/s: 1.5
          • Fix Version/s: None
          • Component/s: HTML Editor (TinyMCE)
          • Labels:
            None
          • Environment:
            Windows XP
          • Affected Branches:
            MOODLE_15_STABLE

            Description

            When I pop up the insert link window for HTML editor, I see a lot of garbled characters on IE6. I am using ja_utf8 lang pack. Firefox works fine.

            This is caused by lib/editor/popups/link_std.php and maybe link.php producing irregular Content-Type tag:

            <meta http-equiv=Content-Type content=text/html; UTF-8 />

            Here is the patch to fix this problem:

            diff -u ../20050317/moodle/lib/editor/popups/link.php lib/editor/popups/link.php

            — ../20050317/moodle/lib/editor/popups/link.php Fri Nov 5 11:15:14 2004

            +++ lib/editor/popups/link.php Fri Mar 18 18:45:45 2005

            @@ -14,7 +14,7 @@

            <html>

            <head>

            <title><?php print_string(insertlink,editor);?></title>

            -<meta http-equiv=Content-Type content=text/html; <?php print_string(thischarset);?> />

            +<meta http-equiv=Content-Type content=text/html; charset=<?php print_string(thischarset);?> />

            <script language=javascript type=text/javascript>

            function onCancel() {

            diff -u ../20050317/moodle/lib/editor/popups/link_std.php lib/editor/popups/link_std.php

            — ../20050317/moodle/lib/editor/popups/link_std.php Wed Feb 9 11:21:50 2005

            +++ lib/editor/popups/link_std.php Fri Mar 18 18:45:59 2005

            @@ -14,7 +14,7 @@

            http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd>

            <html>

            <head>

            -<meta http-equiv=Content-Type content=text/html; <?php print_string(thischarset);?> />

            +<meta http-equiv=Content-Type content=text/html; charset=<?php print_string(thischarset);?> />

            <title><?php print_string(insertlink,editor);?></title>

            <script language=javascript type=text/javascript src=popup.js></script>

            <script language=javascript type=text/javascript>

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  dougiamas Martin Dougiamas added a comment -

                  From Janne Mikkonen (janne.mikkonen at julmajanne.com) Sunday, 20 March 2005, 12:47 AM:

                  Thanks for noticing this! Fixed in MOODLE_14_STABLE and main trunk

                  Show
                  dougiamas Martin Dougiamas added a comment - From Janne Mikkonen (janne.mikkonen at julmajanne.com) Sunday, 20 March 2005, 12:47 AM: Thanks for noticing this! Fixed in MOODLE_14_STABLE and main trunk
                  Hide
                  Permalink
                  mblake Michael Blake added a comment -

                  assign to a valid user

                  Show
                  mblake Michael Blake added a comment - assign to a valid user

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved: