Moodle
  1. Moodle
  2. MDL-27631

"Include questions from sub-categories too" has incorrect default behaviour

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.1.2
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      Go to question bank, where there are some subcategories with some quuestions in them. Then chose the top level category (parent of the mentiond subcategories) from "Select a category", click on checkbox " Also show questions from sub-categories" the questions in subcats should display when this is ticked and not display when this is unticked.

      Show
      Go to question bank, where there are some subcategories with some quuestions in them. Then chose the top level category (parent of the mentiond subcategories) from "Select a category", click on checkbox " Also show questions from sub-categories" the questions in subcats should display when this is ticked and not display when this is unticked.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      17346

      Description

      When viewing a question bank, the "Include questions from sub-categories too" checkbox is unchecked. However, sub-category items are still displayed.

      Checking and unchecking the checkbox fixes the issue temporarily, but these sub-category elements should not be shown when the category page is first viewed.

        Issue Links

          Activity

          Hide
          Mahmoud Kassaei added a comment -
          Show
          Mahmoud Kassaei added a comment - This has been fixed and put on https://github.com/mkassaei/moodle/commit/92e6e128ff76ee6677c6c5724a9d451587658af0 to be reviewed
          Hide
          Tim Hunt added a comment -

          Looks good to me. Thanks Mahmoud. Submitting for integration.

          Show
          Tim Hunt added a comment - Looks good to me. Thanks Mahmoud. Submitting for integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Note: Guess it's intentional not to have the "showquestiontext" checkbox in quiz, correct?

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks! Note: Guess it's intentional not to have the "showquestiontext" checkbox in quiz, correct?
          Hide
          Aparup Banerjee added a comment -

          Thanks, this works for me!

          Show
          Aparup Banerjee added a comment - Thanks, this works for me!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sent upstream and closing, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Sent upstream and closing, many thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: