Moodle
  1. Moodle
  2. MDL-27640

Rating a database activity entry takes user back to list view

    Details

    • Testing Instructions:
      Hide

      Check that javascript is disabled in your site settings.
      Create a database activity with at least 3 items in it. You can use an existing database if you have one.
      Click on "view single" to view individual items. Check that the paging bar works (clicking on numbers takes you to an element. next and previous links work)
      Check that you have at least one item you can rate. This is most easily done by having a student submit an item then log in as the teacher.
      Submit a rating by selecting an item from the rating drop down then clicking "Rate". If this button doesnt appear you dont have Javascript disabled.
      The page should reload and you should be returned to the same database item.

      Show
      Check that javascript is disabled in your site settings. Create a database activity with at least 3 items in it. You can use an existing database if you have one. Click on "view single" to view individual items. Check that the paging bar works (clicking on numbers takes you to an element. next and previous links work) Check that you have at least one item you can rate. This is most easily done by having a student submit an item then log in as the teacher. Submit a rating by selecting an item from the rating drop down then clicking "Rate". If this button doesnt appear you dont have Javascript disabled. The page should reload and you should be returned to the same database item.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
      MDL-27640_database_rating_return_url
    • Rank:
      17304

      Description

      When JavaScript is disabled, rating a database activity entry takes a user back to list view rather than remaining in single view.

        Activity

        Hide
        Sam Hemelryk added a comment -

        Hi Andrew,

        Change looks good however why is that & at the end of line 662? Surely that doesn't need to be there.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi Andrew, Change looks good however why is that & at the end of line 662? Surely that doesn't need to be there. Cheers Sam
        Hide
        Sam Hemelryk added a comment -

        Also worth noting in Master JavaScript rating isn't working for me, would you mind having a test on your site for me and seeing if it works for you.
        I get the following JS error:

        Error: this.Y.io.queue is undefined
        Source File: http://development.sam.local/lib/javascript.php?file=%2Frating%2Fmodule.js&rev=234
        Line: 3

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Also worth noting in Master JavaScript rating isn't working for me, would you mind having a test on your site for me and seeing if it works for you. I get the following JS error: Error: this.Y.io.queue is undefined Source File: http://development.sam.local/lib/javascript.php?file=%2Frating%2Fmodule.js&rev=234 Line: 3 Cheers Sam
        Hide
        Sam Hemelryk added a comment -

        Sorry Andrew - apparently I forgot to click Finish peer-review

        Show
        Sam Hemelryk added a comment - Sorry Andrew - apparently I forgot to click Finish peer-review
        Hide
        Andrew Davis added a comment -

        the this.Y.io.queue problem was fixed as part of MDL-29333. rebasing etc now.

        Show
        Andrew Davis added a comment - the this.Y.io.queue problem was fixed as part of MDL-29333 . rebasing etc now.
        Hide
        Andrew Davis added a comment -

        Ive added a second commit to each branch to remove the unnecessary ampersand.

        Show
        Andrew Davis added a comment - Ive added a second commit to each branch to remove the unnecessary ampersand.
        Hide
        Aparup Banerjee added a comment -

        Thanks Andrew, this has been squashed and integrated. Ready for testing.

        Show
        Aparup Banerjee added a comment - Thanks Andrew, this has been squashed and integrated. Ready for testing.
        Hide
        Rossiani Wijaya added a comment -

        This works great.

        Test passed.

        Show
        Rossiani Wijaya added a comment - This works great. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        git repositories have been updated with your awesome changes, thanks! Closing.

        Show
        Eloy Lafuente (stronk7) added a comment - git repositories have been updated with your awesome changes, thanks! Closing.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: