Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.2
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Language
    • Labels:

      Description

      Moodle forms with required field display at its bottom right:
      There are required fields in this form marked*.
      A space between "marked" and the asterisk is missing.
      It is only matter of changing the string
      $string['somefieldsrequired']
      of the file moodle20/lang/en/form.php
      from

      $string['somefieldsrequired'] = 'There are required fields in this form marked{$a}.';

      to

      $string['somefieldsrequired'] = 'There are required fields in this form marked {$a}.';

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting this.

            I've put it on our backlog and we'll try to get to it as soon as we can.

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can.
            Hide
            koen Koen Roggemans added a comment -

            Assigning to Helen - English language pack issue

            Show
            koen Koen Roggemans added a comment - Assigning to Helen - English language pack issue
            Hide
            tsala Helen Foster added a comment -

            Apologies for not getting around to fixing this issue. Assigning to Gerry in the hope he's more efficient than me!

            Show
            tsala Helen Foster added a comment - Apologies for not getting around to fixing this issue. Assigning to Gerry in the hope he's more efficient than me!
            Hide
            abgreeve Adrian Greeve added a comment -

            Looks good.
            Thanks for the fix Gerry.

            Show
            abgreeve Adrian Greeve added a comment - Looks good. Thanks for the fix Gerry.
            Hide
            gerry Gerard Caulfield added a comment -

            Thanks for the peer review Adrian

            Show
            gerry Gerard Caulfield added a comment - Thanks for the peer review Adrian
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Gerry - this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Gerry - this has been integrated now
            Hide
            andyjdavis Andrew Davis added a comment -

            Works fine.

            I know this is an incredibly simple bug fix but lets not get lazy with the test instructions. They need to define 1) the steps the tester has to take 2) the correct behaviour.

            Show
            andyjdavis Andrew Davis added a comment - Works fine. I know this is an incredibly simple bug fix but lets not get lazy with the test instructions. They need to define 1) the steps the tester has to take 2) the correct behaviour.
            Hide
            gerry Gerard Caulfield added a comment -

            My apologies, I did not write the test instructions, but I should have make sure they were relevant.

            Show
            gerry Gerard Caulfield added a comment - My apologies, I did not write the test instructions, but I should have make sure they were relevant.
            Hide
            daniss Daniele Cordella added a comment -

            no, it is my fault!
            Sure, but... please!

            Show
            daniss Daniele Cordella added a comment - no, it is my fault! Sure, but... please!
            Hide
            gerry Gerard Caulfield added a comment -

            @Daniele The testing is already complete so changing the test now would just make things confusing, which is why I left it as is. All good, I'll write myself a checklist so I don't forget in future.

            Show
            gerry Gerard Caulfield added a comment - @Daniele The testing is already complete so changing the test now would just make things confusing, which is why I left it as is. All good, I'll write myself a checklist so I don't forget in future.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

            Closing as fixed, heading to zzzZZZzzz, niao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao
            Hide
            daniss Daniele Cordella added a comment -

            Thank you all guys.
            Eloy... you went to sleep less than three hours ago and I start my day now.
            What is wrong? Nothing... world is so huge!
            Ah no! We live in the same timezone!!!!! Thanks wise and good friend.

            Show
            daniss Daniele Cordella added a comment - Thank you all guys. Eloy... you went to sleep less than three hours ago and I start my day now. What is wrong? Nothing... world is so huge! Ah no! We live in the same timezone!!!!! Thanks wise and good friend.

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12