Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.2
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Language
    • Labels:

      Description

      Moodle forms with required field display at its bottom right:
      There are required fields in this form marked*.
      A space between "marked" and the asterisk is missing.
      It is only matter of changing the string
      $string['somefieldsrequired']
      of the file moodle20/lang/en/form.php
      from

      $string['somefieldsrequired'] = 'There are required fields in this form marked{$a}.';

      to

      $string['somefieldsrequired'] = 'There are required fields in this form marked {$a}.';

        Gliffy Diagrams

          Activity

          daniss Daniele Cordella created issue -
          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for reporting this.

          I've put it on our backlog and we'll try to get to it as soon as we can.

          Show
          salvetore Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can.
          salvetore Michael de Raadt made changes -
          Field Original Value New Value
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          Fix Version/s DEV backlog [ 10464 ]
          Priority Minor [ 4 ] Trivial [ 5 ]
          Labels triaged
          Difficulty Easy
          Hide
          koen Koen Roggemans added a comment -

          Assigning to Helen - English language pack issue

          Show
          koen Koen Roggemans added a comment - Assigning to Helen - English language pack issue
          koen Koen Roggemans made changes -
          Assignee Koen Roggemans [ koen ] Helen Foster [ tsala ]
          tsala Helen Foster made changes -
          Parent MDL-29160 [ 47184 ]
          Issue Type Improvement [ 4 ] Sub-task [ 5 ]
          Hide
          tsala Helen Foster added a comment -

          Apologies for not getting around to fixing this issue. Assigning to Gerry in the hope he's more efficient than me!

          Show
          tsala Helen Foster added a comment - Apologies for not getting around to fixing this issue. Assigning to Gerry in the hope he's more efficient than me!
          tsala Helen Foster made changes -
          Fix Version/s STABLE backlog [ 10463 ]
          Fix Version/s DEV backlog [ 10464 ]
          Assignee Helen Foster [ tsala ] Gerard Caulfield [ gerry ]
          Affects Version/s 2.2 [ 10656 ]
          gerry Gerard Caulfield made changes -
          Pull Master Diff URL https://github.com/gerrywastaken/moodle/compare/master...m_MDL-27654_add_space_to_somefieldrequired_string
          Pull Master Branch m_MDL-27654_add_space_to_somefieldrequired_string
          Pull 2.0 Diff URL https://github.com/gerrywastaken/moodle/compare/master...20_MDL-27654_add_space_to_somefieldrequired_string
          Pull 2.0 Branch 20_MDL-27654_add_space_to_somefieldrequired_string
          Pull 2.2 Diff URL https://github.com/gerrywastaken/moodle/compare/master...22_MDL-27654_add_space_to_somefieldrequired_string
          Pull 2.1 Branch 21_MDL-27654_add_space_to_somefieldrequired_string
          Pull 2.2 Branch 22_MDL-27654_add_space_to_somefieldrequired_string
          Pull 2.1 Diff URL https://github.com/gerrywastaken/moodle/compare/master...21_MDL-27654_add_space_to_somefieldrequired_string
          Pull from Repository git://github.com/gerrywastaken/moodle.git
          gerry Gerard Caulfield made changes -
          Status Open [ 1 ] Waiting for peer review [ 10012 ]
          Hide
          abgreeve Adrian Greeve added a comment -

          Looks good.
          Thanks for the fix Gerry.

          Show
          abgreeve Adrian Greeve added a comment - Looks good. Thanks for the fix Gerry.
          abgreeve Adrian Greeve made changes -
          Original Estimate 0 minutes [ 0 ]
          Remaining Estimate 0 minutes [ 0 ]
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Peer reviewer abgreeve
          abgreeve Adrian Greeve made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          gerry Gerard Caulfield made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Hide
          gerry Gerard Caulfield added a comment -

          Thanks for the peer review Adrian

          Show
          gerry Gerard Caulfield added a comment - Thanks for the peer review Adrian
          stronk7 Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          samhemelryk Sam Hemelryk made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator samhemelryk
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Gerry - this has been integrated now

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Gerry - this has been integrated now
          samhemelryk Sam Hemelryk made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Fix Version/s 2.1.5 [ 11553 ]
          Fix Version/s 2.2.2 [ 11552 ]
          Fix Version/s STABLE backlog [ 10463 ]
          andyjdavis Andrew Davis made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester andyjdavis
          Hide
          andyjdavis Andrew Davis added a comment -

          Works fine.

          I know this is an incredibly simple bug fix but lets not get lazy with the test instructions. They need to define 1) the steps the tester has to take 2) the correct behaviour.

          Show
          andyjdavis Andrew Davis added a comment - Works fine. I know this is an incredibly simple bug fix but lets not get lazy with the test instructions. They need to define 1) the steps the tester has to take 2) the correct behaviour.
          andyjdavis Andrew Davis made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          gerry Gerard Caulfield added a comment -

          My apologies, I did not write the test instructions, but I should have make sure they were relevant.

          Show
          gerry Gerard Caulfield added a comment - My apologies, I did not write the test instructions, but I should have make sure they were relevant.
          Hide
          daniss Daniele Cordella added a comment -

          no, it is my fault!
          Sure, but... please!

          Show
          daniss Daniele Cordella added a comment - no, it is my fault! Sure, but... please!
          Hide
          gerry Gerard Caulfield added a comment -

          @Daniele The testing is already complete so changing the test now would just make things confusing, which is why I left it as is. All good, I'll write myself a checklist so I don't forget in future.

          Show
          gerry Gerard Caulfield added a comment - @Daniele The testing is already complete so changing the test now would just make things confusing, which is why I left it as is. All good, I'll write myself a checklist so I don't forget in future.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

          Closing as fixed, heading to zzzZZZzzz, niao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao
          stronk7 Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Hide
          daniss Daniele Cordella added a comment -

          Thank you all guys.
          Eloy... you went to sleep less than three hours ago and I start my day now.
          What is wrong? Nothing... world is so huge!
          Ah no! We live in the same timezone!!!!! Thanks wise and good friend.

          Show
          daniss Daniele Cordella added a comment - Thank you all guys. Eloy... you went to sleep less than three hours ago and I start my day now. What is wrong? Nothing... world is so huge! Ah no! We live in the same timezone!!!!! Thanks wise and good friend.
          stronk7 Eloy Lafuente (stronk7) made changes -
          Integration date 17/Feb/12

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12