Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27684

Uninformative error when user session has timed out

    Details

    • Testing Instructions:
      Hide
      1. Enable debugging
      2. Go to your private files
      3. Click "Add"
      4. Open a new browser window to logout your user
      5. Then browse the repository
      6. Make sure you see a proper error saying that the course or activity is not available.
      7. You will also see an alert about not being able to set the user preferences.
      8. Repeat the test with debugging disabled to ensure that the alert() is not displayed.
      Show
      Enable debugging Go to your private files Click "Add" Open a new browser window to logout your user Then browse the repository Make sure you see a proper error saying that the course or activity is not available. You will also see an alert about not being able to set the user preferences. Repeat the test with debugging disabled to ensure that the alert() is not displayed.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_23_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-27684-master

      Description

      To reproduce:

      1. Open the file picker.
      2. Wait for your session to timeout (Or just logout in another tab)
      3. Click on some action in the file picker, you get an error "Unsupported redirect detected, script execution terminated"
        • If you click to close the error, it just come back up

      Probably need to check if the user is logged in and if not, throw an appropriate error message. I'm not sure how to solve how the message just keeps coming back up - maybe send something back with the error json to refresh the page (which would send the user to login).

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Nov/13