Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27692

bullets not numbers in ordered list in topic section in course page view

    Details

    • Testing Instructions:
      Hide

      1. With editing on, go to any course page and edit the topic section at the top of that page.
      2. Make a list of words eg:
      paper
      scissors
      rock
      3. Highlight your list and select 'ordered list' (numerical list) icon in the text editor menu.
      This should produce a list similar to the attached image.
      4. Save your work and then view the text you have just written.
      You should see a numbered list.
      5. Repeat steps 1 thru 4, but create a Label this time and add your list inside the Label. It can be a nested list or a simple list, it matters not as the result should still be the same as 4. above.

      Show
      1. With editing on, go to any course page and edit the topic section at the top of that page. 2. Make a list of words eg: paper scissors rock 3. Highlight your list and select 'ordered list' (numerical list) icon in the text editor menu. This should produce a list similar to the attached image. 4. Save your work and then view the text you have just written. You should see a numbered list. 5. Repeat steps 1 thru 4, but create a Label this time and add your list inside the Label. It can be a nested list or a simple list, it matters not as the result should still be the same as 4. above.
    • Workaround:
      Hide

      Add the following to core.css in base theme...

      ul li,
      .course-content ul.weeks .content .summary ul li,
      .course-content ul.topics .content .summary ul li

      {list-style: disc outside none }

      ol li,
      .course-content ul.weeks .content .summary ol li,
      .course-content ul.topics .content .summary ol li

      {list-style: decimal outside none }

      which will ensure numbered list are rendered correctly.

      Show
      Add the following to core.css in base theme... ul li, .course-content ul.weeks .content .summary ul li, .course-content ul.topics .content .summary ul li {list-style: disc outside none } ol li, .course-content ul.weeks .content .summary ol li, .course-content ul.topics .content .summary ol li {list-style: decimal outside none } which will ensure numbered list are rendered correctly.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27692_master

      Description

      1.) Selecting 'ordered list' (numerical) from the icon in HTML Editor, in the topic section of a course page, only produces bullet points and not numbers as one would expect.

      The attached image, related to this issue, shows 'HTML Editor' view when editing. Whilst the display in the editor is correct, the outcome, for an ORDERED LIST after saving is not rendered as it should be: 1.) A numbered list

        Gliffy Diagrams

          Issue Links

            Activity

            lazydaisy Mary Evans created issue -
            lazydaisy Mary Evans made changes -
            Field Original Value New Value
            Assignee moodle.com [ moodle.com ] Mary Evans [ lazydaisy ]
            lazydaisy Mary Evans made changes -
            Testing Instructions 1. With editing on, go to any course page and edit the topic section at the top of this page.
            2. Make a list of words eg:
            paper
            scissors
            rock
            3. Highlight your list and then select 'ordered list' (numerical list) icon in the text editor menu.
            This give you something which looks like this while in text editor mode...
            1. paper
            2. scissors
            3. rock

            4. Save your work and then view the text you have just written.
            Where there should be numbers all you get is a normal bullet pointed list.
            5. Repeat steps 1 thru 4 but chose an un-ordered list this time.
            This results in a list with no bullet points at all.
            1. With editing on, go to any course page and edit the topic section at the top of that page.
            2. Make a list of words eg:
            paper
            scissors
            rock
            3. Highlight your list and select 'ordered list' (numerical list) icon in the text editor menu.
            This should produce a list similar to the attached image.
            4. Save your work and then view the text you have just written.
            Where there should be numbers all you get is a normal bullet pointed list.
            5. Repeat steps 1 thru 4, but choose an un-ordered list this time.
            This should result in a bullet pointed list, but what you get is just a list of words with no bullet points at all..
            Description 1. Selecting 'ordered list' (numerical list) from the icon in Text Editor, in the topic section of a course page, only produces bullet points and not numbers as one would expect.

            2. Selecting 'un-ordered list' (bullet list) from the icon in Text Editor, in the topic section of a course page, produces no bullet points at all.
            1. Selecting 'ordered list' (numerical) from the icon in HTML Editor, in the topic section of a course page, only produces bullet points and not numbers as one would expect.

            2. Selecting 'un-ordered list' (bullets) from the icon in HTML Editor, in the topic section of a course page, produces no bullet points at all, as one would NOT expect!

            The attached image, related to this issue, shows 'HTML Editor' view when editing. Whilst the display in the editor is correct, the outcome, after saving is not rendered as it should be: 1.) A numbered list 2.) A bullet-pointed list
            Component/s HTML Editor [ 10070 ]
            Component/s Themes [ 10088 ]
            Component/s Course [ 10057 ]
            lazydaisy Mary Evans made changes -
            Summary bullets not numbers in ordered list and no bullets at all in un-oredered list in topic section on course page bullets not numbers in ordered list and no bullets at all in un-ordered list in topic section in course page view
            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting this, Mary.

            I'll ask Sam H to comment.

            Michael;

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting this, Mary. I'll ask Sam H to comment. Michael;
            salvetore Michael de Raadt made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Labels triaged
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Looks like you're on top of this Mary, yell out if there's anything I can help with.
            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Looks like you're on top of this Mary, yell out if there's anything I can help with. Cheers Sam
            Hide
            lazydaisy Mary Evans added a comment -

            Thanks Sam

            Show
            lazydaisy Mary Evans added a comment - Thanks Sam
            Hide
            epsd John Stabinger added a comment -

            Does this look like the same issue?

            http://tracker.moodle.org/browse/MDL-27271

            Might be able to kill two birds with one stone...

            Show
            epsd John Stabinger added a comment - Does this look like the same issue? http://tracker.moodle.org/browse/MDL-27271 Might be able to kill two birds with one stone...
            Hide
            lazydaisy Mary Evans added a comment - - edited

            Hi John,
            Part of that problem has been addressed. However, where the UL works in whatever situation it is in the OL does not. On inspecting the CSS in Firebug I notice that the YUI CSS rule for OL is being overridden by UL which I thought odd, so I have just been testing it.

            I found that if the order is different in the CSS
            Example:
            <code>
            ol li

            { list-style: decimal outside none;}

            ul li

            { list-style: disc outside none;}

            </code>

            OL is overridden in Base theme if this rule is set this way, however, if written the other way round...
            Example:
            <code>
            ul li

            { list-style: disc outside none;}

            ol li

            { list-style: decimal outside none;}

            </code>

            the OL rule works.

            I'm left wondering if this is a case of too many CSS rules at play, as there are lots of UL & OL peppered throughout Moodle style-sheets, or literally a CSS order thing similar to a:link, a:visited, a:hover, a:active, a:focus which MUST be in a specific order to work correctly.

            If this is the case, then the YUI CSS rules for UL & OL have been written the wrong way round in YUI3 CSS. What a lot of messing about for such a small tag!!!

            For this particular fix I'm going to stick with the original CSS rules as written in the MDL Workaround, but also add two more rules to incorporate weekly as well as topic.

            .course-content ul.weeks .content .summary ul li

            {list-style: disc outside none }

            .course-content ul.weeks .content .summary ol li

            {list-style: decimal outside none }

            Cheers
            Mary

            Show
            lazydaisy Mary Evans added a comment - - edited Hi John, Part of that problem has been addressed. However, where the UL works in whatever situation it is in the OL does not. On inspecting the CSS in Firebug I notice that the YUI CSS rule for OL is being overridden by UL which I thought odd, so I have just been testing it. I found that if the order is different in the CSS Example: <code> ol li { list-style: decimal outside none;} ul li { list-style: disc outside none;} </code> OL is overridden in Base theme if this rule is set this way, however, if written the other way round... Example: <code> ul li { list-style: disc outside none;} ol li { list-style: decimal outside none;} </code> the OL rule works. I'm left wondering if this is a case of too many CSS rules at play, as there are lots of UL & OL peppered throughout Moodle style-sheets, or literally a CSS order thing similar to a:link, a:visited, a:hover, a:active, a:focus which MUST be in a specific order to work correctly. If this is the case, then the YUI CSS rules for UL & OL have been written the wrong way round in YUI3 CSS. What a lot of messing about for such a small tag!!! For this particular fix I'm going to stick with the original CSS rules as written in the MDL Workaround, but also add two more rules to incorporate weekly as well as topic. .course-content ul.weeks .content .summary ul li {list-style: disc outside none } .course-content ul.weeks .content .summary ol li {list-style: decimal outside none } Cheers Mary
            Hide
            lazydaisy Mary Evans added a comment -

            Ok...I have been testing this idea again and proved that the order is important in this situation.
            If you add this order set to core.css in base theme in Moodle 2.0.3 (Build 20110525)

            ol li

            {list-style: decimal outside none}


            ul li

            {list-style: disc outside none }

            UL will over-ride OL in course page weekly or topic summary including the lable.

            If you have it set like this...with UL on top...

            ul li

            {list-style: disc outside none}

            ol li

            {list-style: decimal outside none}

            OL works OK.

            Strange but true.

            Mary

            Show
            lazydaisy Mary Evans added a comment - Ok...I have been testing this idea again and proved that the order is important in this situation. If you add this order set to core.css in base theme in Moodle 2.0.3 (Build 20110525) ol li {list-style: decimal outside none} ul li {list-style: disc outside none } UL will over-ride OL in course page weekly or topic summary including the lable. If you have it set like this...with UL on top... ul li {list-style: disc outside none} ol li {list-style: decimal outside none} OL works OK. Strange but true. Mary
            Hide
            lazydaisy Mary Evans added a comment -

            A Before and after view while testing this.

            In either case the Unordered List works without specific CSS.rules

            Show
            lazydaisy Mary Evans added a comment - A Before and after view while testing this. In either case the Unordered List works without specific CSS.rules
            lazydaisy Mary Evans made changes -
            Attachment ordered-list.jpg [ 24005 ]
            lazydaisy Mary Evans made changes -
            Summary bullets not numbers in ordered list and no bullets at all in un-ordered list in topic section in course page view bullets not numbers in ordered list in topic section in course page view
            Testing Instructions 1. With editing on, go to any course page and edit the topic section at the top of that page.
            2. Make a list of words eg:
            paper
            scissors
            rock
            3. Highlight your list and select 'ordered list' (numerical list) icon in the text editor menu.
            This should produce a list similar to the attached image.
            4. Save your work and then view the text you have just written.
            Where there should be numbers all you get is a normal bullet pointed list.
            5. Repeat steps 1 thru 4, but choose an un-ordered list this time.
            This should result in a bullet pointed list, but what you get is just a list of words with no bullet points at all..
            1. With editing on, go to any course page and edit the topic section at the top of that page.
            2. Make a list of words eg:
            paper
            scissors
            rock
            3. Highlight your list and select 'ordered list' (numerical list) icon in the text editor menu.
            This should produce a list similar to the attached image.
            4. Save your work and then view the text you have just written.
            You should see a numbered list.
            5. Repeat steps 1 thru 4, but create a Label this time and add your list inside the Label. It can be a nested list or a simple list, it matters not as the result should still the same as 4. above.
            Description 1. Selecting 'ordered list' (numerical) from the icon in HTML Editor, in the topic section of a course page, only produces bullet points and not numbers as one would expect.

            2. Selecting 'un-ordered list' (bullets) from the icon in HTML Editor, in the topic section of a course page, produces no bullet points at all, as one would NOT expect!

            The attached image, related to this issue, shows 'HTML Editor' view when editing. Whilst the display in the editor is correct, the outcome, after saving is not rendered as it should be: 1.) A numbered list 2.) A bullet-pointed list
            1.) Selecting 'ordered list' (numerical) from the icon in HTML Editor, in the topic section of a course page, only produces bullet points and not numbers as one would expect.

            The attached image, related to this issue, shows 'HTML Editor' view when editing. Whilst the display in the editor is correct, the outcome, for an ORDERED LIST after saving is not rendered as it should be: 1.) A numbered list
            Workaround Add the following to core.css in base theme...

            .course-content ul.topics .content .summary ul li {list-style: disc outside none }
            .course-content ul.topics .content .summary ol li {list-style: decimal outside none }

            which will ensure both
            Add the following to core.css in base theme...

            ul li,
            .course-content ul.weeks .content .summary ul li,
            .course-content ul.topics .content .summary ul li {list-style: disc outside none }

            ol li,
            .course-content ul.weeks .content .summary ol li,
            .course-content ul.topics .content .summary ol li {list-style: decimal outside none }

            which will ensure numbered list are rendered correctly.
            lazydaisy Mary Evans made changes -
            Status Open [ 1 ] Waiting for integration review [ 10010 ]
            Pull Master Diff URL https://github.com/MaryE/moodle/compare/master...MDL-27692_master
            Pull Master Branch MDL-27692_master
            Pull 2.0 Diff URL https://github.com/MaryE/moodle/compare/master...MDL-27692
            Pull 2.0 Branch MDL-27692
            Pull from Repository git://github.com/MaryE/moodle.git
            Testing Instructions 1. With editing on, go to any course page and edit the topic section at the top of that page.
            2. Make a list of words eg:
            paper
            scissors
            rock
            3. Highlight your list and select 'ordered list' (numerical list) icon in the text editor menu.
            This should produce a list similar to the attached image.
            4. Save your work and then view the text you have just written.
            You should see a numbered list.
            5. Repeat steps 1 thru 4, but create a Label this time and add your list inside the Label. It can be a nested list or a simple list, it matters not as the result should still the same as 4. above.
            1. With editing on, go to any course page and edit the topic section at the top of that page.
            2. Make a list of words eg:
            paper
            scissors
            rock
            3. Highlight your list and select 'ordered list' (numerical list) icon in the text editor menu.
            This should produce a list similar to the attached image.
            4. Save your work and then view the text you have just written.
            You should see a numbered list.
            5. Repeat steps 1 thru 4, but create a Label this time and add your list inside the Label. It can be a nested list or a simple list, it matters not as the result should still be the same as 4. above.
            samhemelryk Sam Hemelryk made changes -
            Currently in integration Yes
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Mary this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Mary this has been integrated now.
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester stronk7
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Tested on sections and labels, works ok. So passing.

            But I've detected course->intros are hiding the numbers (and the the bullets). Do we really need to define them everywhere?

            Feel free to ignite new issue about that or whatever, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Tested on sections and labels, works ok. So passing. But I've detected course->intros are hiding the numbers (and the the bullets). Do we really need to define them everywhere? Feel free to ignite new issue about that or whatever, thanks!
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This is now upstream, yay! Many thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This is now upstream, yay! Many thanks!
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Fix Version/s 2.0.4 [ 10652 ]
            Fix Version/s STABLE backlog [ 10463 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes
            Integration date 9/Jun/11
            salvetore Michael de Raadt made changes -
            Link This issue will help resolve MDL-27826 [ MDL-27826 ]
            salvetore Michael de Raadt made changes -
            Link This issue caused a regression MDL-30471 [ MDL-30471 ]
            salvetore Michael de Raadt made changes -
            Link This issue has been marked as being related by MDL-31044 [ MDL-31044 ]

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Aug/11