Moodle
  1. Moodle
  2. MDL-27704

Overlapping problems in fusion theme

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.0.4
    • Component/s: Themes
    • Labels:
    • Environment:
      Any browser seems to reproduce the problems consistently
    • Rank:
      17384

      Description

      This is one followup of MDL-25512

      After changing some "common" rules in the canvas theme, it seems that the fusion theme is showing some problems. Copied from the original issue:

      by Michael: "In the Fusion theme, the breadcrumbs appeared overlapping the header boundary and is unreadable (I'll attach a screenshot). The font size is OK, but this seems to be a problem that has occurred with this change that needs to be fixed. The problem was consistent across all browsers."

        Issue Links

          Activity

          Hide
          Mary Evans added a comment -

          Will fix , thanks

          Patch: .navbar

          {padding-top: 10px;}

          Show
          Mary Evans added a comment - Will fix , thanks Patch: .navbar {padding-top: 10px;}
          Hide
          Mary Evans added a comment -

          Work started, patch made and committed. Now ready for integration.

          Show
          Mary Evans added a comment - Work started, patch made and committed. Now ready for integration.
          Hide
          Sam Hemelryk added a comment -

          Thanks Mary this has been integrated now.
          During integration I fixed up a missing close bracket you had accidentally deleted.
          Also I think there was a mix up somewhere along the line both of your branches are based on master. For MOODLE_20_STABLE I cherry-picked your changes across.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Mary this has been integrated now. During integration I fixed up a missing close bracket you had accidentally deleted. Also I think there was a mix up somewhere along the line both of your branches are based on master. For MOODLE_20_STABLE I cherry-picked your changes across. Cheers Sam
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Tested as instructed, I don't see any overlapping in front/course pages. Passing, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Tested as instructed, I don't see any overlapping in front/course pages. Passing, thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is now upstream, yay! Many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - This is now upstream, yay! Many thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: