Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28443 Action logging improvements META
  3. MDL-27705

Log entries for resources not updated during 1.9 to 2.0 upgrade process

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Critical
    • Resolution: Won't Fix
    • Affects Version/s: 2.0.3
    • Fix Version/s: None
    • Component/s: Resource
    • Labels:
    • Database:
      Any
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      In the 1.9 to 2.0 upgrade process, as resource types are converted to their new respective activities the logs are not updated.

      This is a problem for the recent activity block as the print_recent_activity function does not have logic in it to look up the new module name or instance id (when looking for "add mod", "delete mod", or "update mod" entries). When execution reaches this point, the activity gets skipped (if now a url, page, etc):

      if (!isset($modinfo->instances[$modname][$instanceid])) {
          if ($log->action == 'add mod') {
              // do not display added and later deleted activities
              $newgones[$log->info] = true;
          }
          continue;
      }

      This is also a problem for us independent of that function because we use the logs in other plugins we have developed. We'd rather have the performance hit of updating the logs upfront rather than having to do a lookup for each log entry that is a resource.

      Is it possible to update the log entries (including the "add mod", "update mod", and "delete mod" entries) during the 1.9 to 2.0 upgrade process?

        Attachments

          Activity

            People

            Assignee:
            dmonllao David Monllaó
            Reporter:
            sbc24 Sam Chaffee
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: