Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27709

Typo in question/type/numerical/db/upgrade.php

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Duplicate
    • 2.0
    • None
    • Questions
    • None
    • MOODLE_20_STABLE

    Description

      I suspect that the upgrade step 2009100101 in numerical qtype upgrade has a typo. The code

      $record->instructions = text_to_html($record->questiontext, false, false, true);

      copies the question text into the numerical units instructions. Was that intentional? Note that the doc block above this code is a bit confusing and it indicates that this part was copied from qtype_match so this text_to_html() conversion could be a relict of that.

      Anyway, on backup19 conversion, I am not replaying this line yet unless it is confirmed that the question text should be really copied into the instructions.

      Attachments

        Issue Links

          Activity

            People

              timhunt Tim Hunt
              mudrd8mz David Mudrák (@mudrd8mz)
              Safat Shahin, Tim Hunt, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Kevin Percy, Laurent David, Mathew May, Mihail Geshoski, Raquel Ortega, Sabina Abellan, Sander Bangma, Sara Arjona (@sarjona), Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: