Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27709

Typo in question/type/numerical/db/upgrade.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Questions
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      I suspect that the upgrade step 2009100101 in numerical qtype upgrade has a typo. The code

      $record->instructions = text_to_html($record->questiontext, false, false, true);

      copies the question text into the numerical units instructions. Was that intentional? Note that the doc block above this code is a bit confusing and it indicates that this part was copied from qtype_match so this text_to_html() conversion could be a relict of that.

      Anyway, on backup19 conversion, I am not replaying this line yet unless it is confirmed that the question text should be really copied into the instructions.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: