Moodle
  1. Moodle
  2. MDL-27716

provide language string for "Close" popup window in Cloze question overlib feedback

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.12, 2.0
    • Fix Version/s: 1.9.13, 2.0.4
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a multi-answer question with feedback. (You can copy and paste the big example from Moodle docs.)
      2. Preview the question. Check that the feedback overlib pop-up has the word Close in the current language.
      3. Switch your Moodle to a different language.
      4. Preview again, and check that the word Close has now been translated to the new language.

      Show
      1. Create a multi-answer question with feedback. (You can copy and paste the big example from Moodle docs.) 2. Preview the question. Check that the feedback overlib pop-up has the word Close in the current language. 3. Switch your Moodle to a different language. 4. Preview again, and check that the word Close has now been translated to the new language.
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Pull from Repository:
    • Rank:
      17392

      Description

      provide language string for "Close" popup window in Cloze question overlib feedback
      see http://moodle.org/mod/forum/discuss.php?d=176402
      attached patch for 1.9 ; the fix for 2.0 would be the same

        Activity

        Hide
        Tim Hunt added a comment -

        Note that in 2.1, I finally changed Cloze so that it does not use overlib.

        Show
        Tim Hunt added a comment - Note that in 2.1, I finally changed Cloze so that it does not use overlib.
        Hide
        Joseph Rézeau added a comment -

        @Tim,
        I am currently testing Moodle 2.1dev (Build: 20110525) and the Cloze question is still using overlib for the popup feedback. Maybe your change is more recent than that or not yet committed to the github repository?

        Show
        Joseph Rézeau added a comment - @Tim, I am currently testing Moodle 2.1dev (Build: 20110525) and the Cloze question is still using overlib for the popup feedback. Maybe your change is more recent than that or not yet committed to the github repository?
        Hide
        Tim Hunt added a comment -

        My change is MDL-20636 which is not yet integrated.

        Show
        Tim Hunt added a comment - My change is MDL-20636 which is not yet integrated.
        Hide
        Tim Hunt added a comment -

        As noted above, this is only required on 1.9 and 2.0 branches.

        Show
        Tim Hunt added a comment - As noted above, this is only required on 1.9 and 2.0 branches.
        Hide
        Tim Hunt added a comment -

        Thanks Joseph. Sorry it took me so long to review this.

        Show
        Tim Hunt added a comment - Thanks Joseph. Sorry it took me so long to review this.
        Hide
        Sam Hemelryk added a comment -

        Thanks guys - this has been integrated now.
        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Thanks guys - this has been integrated now. Cheers Sam
        Hide
        Rajesh Taneja added a comment -

        Works Great
        Thanks for providing the patch Joseph.

        Show
        Rajesh Taneja added a comment - Works Great Thanks for providing the patch Joseph.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        If there is a will, there is a way, and you found it! Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - If there is a will, there is a way, and you found it! Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: