Moodle
  1. Moodle
  2. MDL-27734

Weights of example submission assessments set incorrectly during the workshop 1.9 => 2.0 upgrade

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.0.4
    • Component/s: Workshop
    • Labels:
    • Testing Instructions:
      Hide

      Note: this can be effectively tested together with MDL-27733

      • In Moodle 1.9, create a workshop using a teacher's weight > 1
      • Define an example submission and assess it as a teacher
      • As a student, assess that example submission
      • Upgrade the site to 2.0
      • TEST: make sure that the example submission and its reference assessment is defined correctly
      Show
      Note: this can be effectively tested together with MDL-27733 In Moodle 1.9, create a workshop using a teacher's weight > 1 Define an example submission and assess it as a teacher As a student, assess that example submission Upgrade the site to 2.0 TEST: make sure that the example submission and its reference assessment is defined correctly
    • Workaround:
      Hide

      Do not use example submissions. Do not use workshops.

      Show
      Do not use example submissions. Do not use workshops.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27734-workshop-example-weight
    • Rank:
      17413

      Description

      In Workshop 2.0, the weight of example submission assessment has a special meaning. The weight = 1 indicates that the assessment is a reference assessment. The weight = 0 is a student's assessment. However, during the upgrade from 1.9, the weights are not set to these values correctly. Instead, the students' assessment have the weight set to 1 and the teacher's (reference) assessments have $teacherweight (1 or bigger) set.

      This is a malicious bug and there is no easy way how to recover already upgraded data. On the other hand, the example submissions do not influence grades so I suggest we just fix the upgrade path without trying to amend already upgraded data.

        Activity

        Hide
        Sam Hemelryk added a comment -

        Looks good to me thanks David.
        Once I've checked with Eloy that it is OK for things to be sent upstream this can go in.

        Show
        Sam Hemelryk added a comment - Looks good to me thanks David. Once I've checked with Eloy that it is OK for things to be sent upstream this can go in.
        Hide
        Sam Hemelryk added a comment -

        Thanks David this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks David this has been integrated now
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Passing after commenting with David, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Passing after commenting with David, thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This is now upstream, yay! Many thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - This is now upstream, yay! Many thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: