IMO this function should return an empty string - it's also used in the socialplus course format.

Thanks for reporting this.

I've put it on our backlog and we'll try to get to it as soon as we can.

Raising the priority on this so we can be sure to give it some love, post-2.1.

Michael;

Hi Rosie,

my vote would be to remove this code that Skodak added:
if (!is_enrolled($context, $USER, '', true))

the function forum_get_subscribe_link is also used in other 3rd party contrib course formats - so this bug appears in other code that expects the function to return a link or empty if no link is available.

Thanks Dan for the suggestion.

I created a patch to remove the 'no' string.

Assigning to Raj for peer review.

Hello Rossie,

Can you please confirm the behavior of forum_get_subscribe_link, for guest users.
It seems like previously we don't allow guest to get a link and now removing this check changes that behavior.

Probably, we can leave if statement and return empty string (as expected.)

  if (!is_enrolled($context, $USER, '', true)) {
      return '';
  }  

good point Raj - +1 to keep is_enrolled but return ''

Thanks Dan and Rossie,
It looks Good to me

Raj,

Yup,user needs to enroll to a course in order to be able to subscribe to a forum.

Thanks Raj for reviewing.

Submitting for integration.

Integrated, thanks!

Looks fine.

Congratulations - this fix has just been released in the weeklies.