[MDL-27755] Course search does not include idnumber or shortname - Moodle Tracker

XML

Word

Printable

Database:

Any
Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
Fixed Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE
Pull from Repository:
git://github.com/rwijaya/moodle.git
Pull Main Branch:
~~MDL-27755~~
Pull Main Diff URL:
https://github.com/rwijaya/moodle/compare/master...MDL-27755
Difficulty:
Easy
Testing Instructions:

Hide

1. login as admin
2. from side block, site admin > courses > add/edit courses
3. select course categories
4. list of courses will be display and search courses input box should be display under re-sort and add new course button.

search a course by name, id or shortname.

Note: search text must contains at least 2 characters.

Show
1. login as admin 2. from side block, site admin > courses > add/edit courses 3. select course categories 4. list of courses will be display and search courses input box should be display under re-sort and add new course button. search a course by name, id or shortname. Note: search text must contains at least 2 characters.

The latest get_courses_search() does not search the idnumber or shortname.

Around line 720 in /lib/datalib.php

Replace

    $concat = $DB->sql_concat('c.summary', "' '", 'c.fullname');

With

    $concat = $DB->sql_concat('c.summary', "' '", 'c.fullname', "' '",'c.idnumber', "' '", 'c.shortname');

Similar issue reported and fixed for 1.9: ~~MDL-19078~~

is duplicated by

MDL-25277 Cannot search by shortname in course search

Participants:: Eloy Lafuente (stronk7), Iñigo Zendegi, James Ballard, Michael de Raadt, Rajesh Taneja, Rossiani Wijaya, Sam Hemelryk