Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27783

Do not update the 'enabled' field during service upgrade

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.0.4
    • Component/s: Web Services
    • Labels:
      None

      Description

      On upgrade, enablemobile feature get disabled

      Plugins > webservices > External Service > Enable the mobile web services
      Bump version.php and upgrade
      Check that enable mobile web services is still enabled.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            jerome Jérôme Mouneyrac added a comment -

            This is a bug in the lib/upgradelib.php script. I think whatever the 'enabled' attribut is set to, on update we should never update the 'enabled' status of a built-in service. It is only used for installation. if the developer needs to change it, it can write some upgrade code in lib/db/upgrade.php.

            Show
            jerome Jérôme Mouneyrac added a comment - This is a bug in the lib/upgradelib.php script. I think whatever the 'enabled' attribut is set to, on update we should never update the 'enabled' status of a built-in service. It is only used for installation. if the developer needs to change it, it can write some upgrade code in lib/db/upgrade.php.
            Hide
            jerome Jérôme Mouneyrac added a comment -

            rebased both STABLE and HEAD. no whitespaces, no version to bump.

            Show
            jerome Jérôme Mouneyrac added a comment - rebased both STABLE and HEAD. no whitespaces, no version to bump.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Jerome this has been integrate now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Jerome this has been integrate now.
            Hide
            jerome Jérôme Mouneyrac added a comment -

            Thank you.

            Show
            jerome Jérôme Mouneyrac added a comment - Thank you.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Confirmed working - thanks Jerome

            Show
            samhemelryk Sam Hemelryk added a comment - Confirmed working - thanks Jerome
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Upstream, upstream, this is part of upstream, upstream... thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Upstream, upstream, this is part of upstream, upstream... thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Aug/11