Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: Libraries
    • Labels:
      None
    • Testing Instructions:
      Hide

      No need to test - the fix is needed for tools like AMOS that need to detect the component type by its name and the plugin manager uses the full normalized component name when calling get_string().

      If you want to test anyway, use the following script put in the Moodle root folder:

      <?php
      define('CLI_SCRIPT', 1);
      require('config.php');
      print_r(normalize_component('plugin'));
      

      it output should be

      Array
      (
          [0] => core
          [1] => plugin
      )
      

      (currently it reports the type as "mod" which is the bug).

      Show
      No need to test - the fix is needed for tools like AMOS that need to detect the component type by its name and the plugin manager uses the full normalized component name when calling get_string(). If you want to test anyway, use the following script put in the Moodle root folder: <?php define('CLI_SCRIPT', 1); require('config.php'); print_r(normalize_component('plugin')); it output should be Array ( [0] => core [1] => plugin ) (currently it reports the type as "mod" which is the bug).
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27792-plugin-subsystem
    • Rank:
      16486

      Description

      The new plugin manager defines its strings in lang/en/plugin.php. However I forgot to add this to the whitelist of core subsystems.

        Activity

        Hide
        Sam Hemelryk added a comment -

        Thanks David, this has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks David, this has been integrated now.
        Hide
        Sam Hemelryk added a comment -

        Tested during integrated

        Show
        Sam Hemelryk added a comment - Tested during integrated
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Upstream, upstream, this is part of upstream, upstream... thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Upstream, upstream, this is part of upstream, upstream... thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: