Moodle
  1. Moodle
  2. MDL-27793

Problem with translated terms for 'login name' with some themes

    Details

    • Testing Instructions:
      Hide

      (0) Install non english languages and RTL languages too as German or Spanish and Hebrew (rtl) logout and look at login page.

      Part A : left-to-right languages

      1)
      i) test that no clipping happens (as in screenshot) to long labels for ['username'] and ['password']. (you can also make the word there very long by editing the html or lang file)
      ii) test that no wrapping to those labels happen when the window is made smaller.

      2) test (1) in all core themes in the master branch. In master branch test also that the 'remember username' is centralized and doesn't wrap unnecessarily.

      3) test (1) in all core themes in affected stable branches. (if fix is applied there)

      4) include testing this in different browsers and at different screen resolution (From Sam's last peer-review comment)
      Part B : perform (1 - 3) but with RTL languages this time.
      (hint: lang/en/langconfig.php -> direction -> 'ltr' can be tweaked too)

      Show
      (0) Install non english languages and RTL languages too as German or Spanish and Hebrew (rtl) logout and look at login page. Part A : left-to-right languages 1) i) test that no clipping happens (as in screenshot) to long labels for ['username'] and ['password'] . (you can also make the word there very long by editing the html or lang file) ii) test that no wrapping to those labels happen when the window is made smaller. 2) test (1) in all core themes in the master branch. In master branch test also that the 'remember username' is centralized and doesn't wrap unnecessarily. 3) test (1) in all core themes in affected stable branches. (if fix is applied there) 4) include testing this in different browsers and at different screen resolution (From Sam's last peer-review comment) Part B : perform (1 - 3) but with RTL languages this time. (hint: lang/en/langconfig.php -> direction -> 'ltr' can be tweaked too)
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      17445

      Description

      In German language 'login name' is one long word 'Anmeldename'. At login page some new themes set the description for the field on the left side, others put them on top the field. In German pages the theme cuts the last sign and the word is not complete. There are also other languages that use long terms but with several words (as in spanish).

      The area for the word should be wider and we don't get problems. Generally the place should be wide enough to add each term. Also the two lines in spanish don't look good.

      1. anomaly.png
        35 kB
      2. ff_m21_formal_white.png
        72 kB
      3. ff_m22_master_formal_white.png
        72 kB
      4. ie8_im22_formal_white.png
        56 kB
      5. ie8_m21_formal_white_1px_indent.png
        49 kB
      6. login.png
        61 kB
      7. m21_m22_master_anomaly_ie8.png
        8 kB

        Issue Links

          Activity

          Ralf Hilgenstock created issue -
          Ralf Hilgenstock made changes -
          Field Original Value New Value
          Priority Minor [ 4 ] Major [ 3 ]
          Michael de Raadt made changes -
          Fix Version/s STABLE backlog [ 10463 ]
          Labels triaged
          Affects Version/s 2.0 [ 10122 ]
          Affects Version/s 2.0.1 [ 10420 ]
          Component/s Forms Library [ 10091 ]
          Ralf Hilgenstock made changes -
          Testing Instructions Install non english languages as German or Spanish and start login page. See screenshots
          Martin Dougiamas made changes -
          Priority Major [ 3 ] Blocker [ 1 ]
          Labels triaged partner triaged
          moodle.com made changes -
          Fix Version/s STABLE Sprint 13 [ 10952 ]
          Fix Version/s STABLE backlog [ 10463 ]
          Aparup Banerjee made changes -
          Assignee Patrick Malley [ ptrkmkl ] Aparup Banerjee [ nebgor ]
          Aparup Banerjee made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Aparup Banerjee made changes -
          moodle.com made changes -
          Fix Version/s STABLE Sprint 14 [ 11050 ]
          Fix Version/s STABLE Sprint 13 [ 10952 ]
          Aparup Banerjee made changes -
          Aparup Banerjee made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Peer reviewer samhemelryk
          Sam Hemelryk made changes -
          Original Estimate 0 minutes [ 0 ]
          Remaining Estimate 0 minutes [ 0 ]
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Sam Hemelryk made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          Aparup Banerjee made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Testing Instructions Install non english languages as German or Spanish and start login page. See screenshots (0) Install non english languages and RTL languages too as German or Spanish and Hebrew (rtl) logout and look at login page.

          Part A : left-to-right languages

          1) in master , test that no clipping happens (as in screenshot) to long labels for ['username'] and ['password']. (you can also make the word there very long by editing the html or lang file)

          2) test (1) in all core themes in the master branch.

          3) test (1) in all core themes in affected stable branches. (if fix is applied there)

          Part B : perform (1 - 3) but with RTL languages this time.
          (hint: lang/en/langconfig.php -> direction -> 'ltr' can be tweaked too)

          Aparup Banerjee made changes -
          Testing Instructions (0) Install non english languages and RTL languages too as German or Spanish and Hebrew (rtl) logout and look at login page.

          Part A : left-to-right languages

          1) in master , test that no clipping happens (as in screenshot) to long labels for ['username'] and ['password']. (you can also make the word there very long by editing the html or lang file)

          2) test (1) in all core themes in the master branch.

          3) test (1) in all core themes in affected stable branches. (if fix is applied there)

          Part B : perform (1 - 3) but with RTL languages this time.
          (hint: lang/en/langconfig.php -> direction -> 'ltr' can be tweaked too)

          (0) Install non english languages and RTL languages too as German or Spanish and Hebrew (rtl) logout and look at login page.

          Part A : left-to-right languages

          1)
          i) test that no clipping happens (as in screenshot) to long labels for ['username'] and ['password']. (you can also make the word there very long by editing the html or lang file)
          ii) test that no wrapping to those labels happen when the window is made smaller.

          2) test (1) in all core themes in the master branch.

          3) test (1) in all core themes in affected stable branches. (if fix is applied there)

          Part B : perform (1 - 3) but with RTL languages this time.
          (hint: lang/en/langconfig.php -> direction -> 'ltr' can be tweaked too)

          Aparup Banerjee made changes -
          Testing Instructions (0) Install non english languages and RTL languages too as German or Spanish and Hebrew (rtl) logout and look at login page.

          Part A : left-to-right languages

          1)
          i) test that no clipping happens (as in screenshot) to long labels for ['username'] and ['password']. (you can also make the word there very long by editing the html or lang file)
          ii) test that no wrapping to those labels happen when the window is made smaller.

          2) test (1) in all core themes in the master branch.

          3) test (1) in all core themes in affected stable branches. (if fix is applied there)

          Part B : perform (1 - 3) but with RTL languages this time.
          (hint: lang/en/langconfig.php -> direction -> 'ltr' can be tweaked too)

          (0) Install non english languages and RTL languages too as German or Spanish and Hebrew (rtl) logout and look at login page.

          Part A : left-to-right languages

          1)
          i) test that no clipping happens (as in screenshot) to long labels for ['username'] and ['password']. (you can also make the word there very long by editing the html or lang file)
          ii) test that no wrapping to those labels happen when the window is made smaller.

          2) test (1) in all core themes in the master branch. In master branch test also that the 'remember username' is centralized and doesn't wrap unnecessarily.

          3) test (1) in all core themes in affected stable branches. (if fix is applied there)

          Part B : perform (1 - 3) but with RTL languages this time.
          (hint: lang/en/langconfig.php -> direction -> 'ltr' can be tweaked too)

          Sam Hemelryk made changes -
          Currently in integration Yes
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Reopened [ 4 ]
          Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes
          moodle.com made changes -
          Affects Version/s STABLE Sprint 15 [ 11158 ]
          Affects Version/s 2.0.3 [ 10537 ]
          moodle.com made changes -
          Fix Version/s STABLE Sprint 15 [ 11158 ]
          Fix Version/s STABLE Sprint 14 [ 11050 ]
          Michael de Raadt made changes -
          Affects Version/s 2.0.3 [ 10537 ]
          Affects Version/s STABLE Sprint 15 [ 11158 ]
          Aparup Banerjee made changes -
          Status Reopened [ 4 ] Development in progress [ 3 ]
          Aparup Banerjee made changes -
          Link This issue has a non-specific relationship to MDL-29940 [ MDL-29940 ]
          Aparup Banerjee made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Sam Hemelryk made changes -
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Sam Hemelryk made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          Aparup Banerjee made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Aparup Banerjee made changes -
          Testing Instructions (0) Install non english languages and RTL languages too as German or Spanish and Hebrew (rtl) logout and look at login page.

          Part A : left-to-right languages

          1)
          i) test that no clipping happens (as in screenshot) to long labels for ['username'] and ['password']. (you can also make the word there very long by editing the html or lang file)
          ii) test that no wrapping to those labels happen when the window is made smaller.

          2) test (1) in all core themes in the master branch. In master branch test also that the 'remember username' is centralized and doesn't wrap unnecessarily.

          3) test (1) in all core themes in affected stable branches. (if fix is applied there)

          Part B : perform (1 - 3) but with RTL languages this time.
          (hint: lang/en/langconfig.php -> direction -> 'ltr' can be tweaked too)

          (0) Install non english languages and RTL languages too as German or Spanish and Hebrew (rtl) logout and look at login page.

          Part A : left-to-right languages

          1)
          i) test that no clipping happens (as in screenshot) to long labels for ['username'] and ['password']. (you can also make the word there very long by editing the html or lang file)
          ii) test that no wrapping to those labels happen when the window is made smaller.

          2) test (1) in all core themes in the master branch. In master branch test also that the 'remember username' is centralized and doesn't wrap unnecessarily.

          3) test (1) in all core themes in affected stable branches. (if fix is applied there)

          4) include testing this in different browsers and at different screen resolution (From Sam's last peer-review comment)
          Part B : perform (1 - 3) but with RTL languages this time.
          (hint: lang/en/langconfig.php -> direction -> 'ltr' can be tweaked too)

          Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          Aparup Banerjee made changes -
          Status Waiting for integration review [ 10010 ] Reopened [ 4 ]
          Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          moodle.com made changes -
          Fix Version/s STABLE Sprint 16 [ 11350 ]
          Fix Version/s STABLE Sprint 15 [ 11158 ]
          moodle.com made changes -
          Labels partner triaged sprinting
          Michael de Raadt made changes -
          Labels sprinting partner sprinting triaged
          Michael de Raadt made changes -
          Fix Version/s STABLE Sprint 17 [ 11550 ]
          Fix Version/s STABLE Sprint 16 [ 11350 ]
          Aparup Banerjee made changes -
          Status Reopened [ 4 ] Development in progress [ 3 ]
          Aparup Banerjee made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.2 [ 10656 ]
          Affects Version/s 2.1 [ 10370 ]
          Fix Version/s 2.1.5 [ 11553 ]
          Fix Version/s 2.2.2 [ 11552 ]
          Michael de Raadt made changes -
          Tester rwijaya
          Rossiani Wijaya made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Rossiani Wijaya made changes -
          Attachment anomaly.png [ 27110 ]
          Attachment m21_m22_master_anomaly_ie8.png [ 27111 ]
          Attachment ff_m21_formal_white.png [ 27112 ]
          Attachment ff_m22_master_formal_white.png [ 27113 ]
          Attachment ie8_im22_formal_white.png [ 27114 ]
          Attachment ie8_m21_formal_white_1px_indent.png [ 27115 ]
          Rossiani Wijaya made changes -
          Status Testing in progress [ 10011 ] Problem during testing [ 10007 ]
          Eloy Lafuente (stronk7) made changes -
          Status Problem during testing [ 10007 ] Integration review in progress [ 10004 ]
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Rossiani Wijaya made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Rossiani Wijaya made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 01/Mar/12
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s STABLE Sprint 17 [ 11550 ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: