Moodle
  1. Moodle
  2. MDL-27800

Notices from restore when there are no files

    Details

    • Testing Instructions:
      Hide

      1. Create a new Moodle installation.
      2. Go to Site administration -> Front page -> Front page restores.

      Show
      1. Create a new Moodle installation. 2. Go to Site administration -> Front page -> Front page restores.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Rank:
      17449

      Description

      Steps to reproduce:

      1. Make a new install of Moodle 2.1 dev (this may also affect 2.0) (May not need to be a completely fresh install, just one which has not had many files uploaded.)

      2. Go to Site administration -> Front page -> Front page restore

      Observe:

      Notice: Trying to get property of non-object in /fs1/www_root/tjh238/moodle_qe2/files/index.php on line 64

      Notice: Trying to get property of non-object in /fs1/www_root/tjh238/moodle_qe2/files/index.php on line 65

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          Actually, in this situation, I cannot see any way to get rid of the message "No files available". Why is there no filepicker?

          Show
          Tim Hunt added a comment - Actually, in this situation, I cannot see any way to get rid of the message "No files available". Why is there no filepicker?
          Hide
          Helen Foster added a comment -

          Just noting that this issue also affects Moodle 2.2 - I ran into it on http://qa.moodle.net/. In addition to the notices, the navigation was messed up ('My home > Files' in the navigation bar) and the site header was missing.

          Show
          Helen Foster added a comment - Just noting that this issue also affects Moodle 2.2 - I ran into it on http://qa.moodle.net/ . In addition to the notices, the navigation was messed up ('My home > Files' in the navigation bar) and the site header was missing.
          Hide
          Charles Fulton added a comment -

          We're seeing the same behavior at Lafayette under the 2.3 release. I think this is just a matter of pointing the site administration link to the same place as the Front page settings navigation block. This does nothing to resolve MDL-31500 but at least the behavior is consistent.

          Show
          Charles Fulton added a comment - We're seeing the same behavior at Lafayette under the 2.3 release. I think this is just a matter of pointing the site administration link to the same place as the Front page settings navigation block. This does nothing to resolve MDL-31500 but at least the behavior is consistent.
          Hide
          Frédéric Massart added a comment -

          Thanks for your patch Charles, this looks good to me! Feel free to push it for integration whenever your are ready.

          Show
          Frédéric Massart added a comment - Thanks for your patch Charles, this looks good to me! Feel free to push it for integration whenever your are ready.
          Hide
          Frédéric Massart added a comment -

          Submitting for integration as Charles does not have permissions to do so. This patch should be easily cherry-picked in 2.2 and 2.3

          Show
          Frédéric Massart added a comment - Submitting for integration as Charles does not have permissions to do so. This patch should be easily cherry-picked in 2.2 and 2.3
          Hide
          Sam Hemelryk added a comment -

          Thanks guys, this has been integrate now and cherry-picked to stable branches.

          Show
          Sam Hemelryk added a comment - Thanks guys, this has been integrate now and cherry-picked to stable branches.
          Hide
          Jason Fowler added a comment -

          No details about an expected outcome, but everything seems to be working

          Show
          Jason Fowler added a comment - No details about an expected outcome, but everything seems to be working
          Hide
          Dan Poltawski added a comment -

          Congratulations!

          You've made it into the weekly release!

          Thanks for your contribution - here are some random drummers to keep you inspired for the next week!
          http://www.youtube.com/watch?v=_QhpHUmVCmY

          Show
          Dan Poltawski added a comment - Congratulations! You've made it into the weekly release! Thanks for your contribution - here are some random drummers to keep you inspired for the next week! http://www.youtube.com/watch?v=_QhpHUmVCmY

            People

            • Votes:
              8 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: