Moodle

Moodle 2.0 backup throws away debuginfor from nested exceptions

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.1, 2.2
  • Fix Version/s: 2.1.1
  • Component/s: Backup
  • Labels:

Description

I am getting the error

Can not read file, either file does not exist or there are permission problems

with stack trace

  • line 90 of /backup/util/helper/backup_file_manager.class.php: call to stored_file->copy_content_to()
  • line 102 of /backup/moodle2/backup_custom_fields.php: call to backup_file_manager::copy_file_moodle2backup()
  • line 70 of /backup/util/structure/backup_nested_element.class.php: call to file_nested_element->fill_values()
  • line 94 of /backup/moodle2/backup_custom_fields.php: call to backup_nested_element->process()
  • line 95 of /backup/util/structure/backup_nested_element.class.php: call to file_nested_element->process()
  • line 95 of /backup/util/plan/backup_structure_step.class.php: call to backup_nested_element->process()
  • line 153 of /backup/util/plan/base_task.class.php: call to backup_structure_step->execute()
  • line 148 of /backup/util/plan/base_plan.class.php: call to base_task->execute()
  • line 105 of /backup/util/plan/backup_plan.class.php: call to base_plan->execute()
  • line 293 of /backup/controller/backup_controller.class.php: call to backup_plan->execute()
  • line 111 of /backup/util/ui/backup_ui.class.php: call to backup_controller->execute_plan()
  • line 87 of /backup/backup.php: call to backup_ui->execute()

As far as I can see, there is no information there that helps me locate the problem, beyond knowing it is one of the files associated with my course.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Hang on a sec, and I will push a branch to github with some ideas.

Show
Tim Hunt added a comment - Hang on a sec, and I will push a branch to github with some ideas.
Hide
Permalink
Tim Hunt added a comment -

https://github.com/timhunt/moodle/compare/MDL-27787...MDL-27821

The first commit you should get integrated ASAP.

The second commit is my attempt to get the error message to include some useful information about what is going on. Sadly, it is a failed attempt. I can't work out how to get the kind of information you need to make the error diagnosable, but this is the kind of information that the backup system should include when it throws an exception.

Show
Tim Hunt added a comment - https://github.com/timhunt/moodle/compare/MDL-27787...MDL-27821 The first commit you should get integrated ASAP. The second commit is my attempt to get the error message to include some useful information about what is going on. Sadly, it is a failed attempt. I can't work out how to get the kind of information you need to make the error diagnosable, but this is the kind of information that the backup system should include when it throws an exception.
Hide
Permalink
Tim Hunt added a comment -

Sorry for the rant above. It was written in a moment of stress.

However, there was one useful commit there, which I have not submitted for integration.

Please can we have this on 2.1 and master branches.

Show
Tim Hunt added a comment - Sorry for the rant above. It was written in a moment of stress. However, there was one useful commit there, which I have not submitted for integration. Please can we have this on 2.1 and master branches.
Hide
Permalink
Tim Hunt added a comment -

I thought I had submitted this for integration, but somehow I must have clicked the wrong button.

Show
Tim Hunt added a comment - I thought I had submitted this for integration, but somehow I must have clicked the wrong button.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

crap, I remember perfectly I had to play with those params because there was something "extra" in moodle_exception. It seems the extra gone and I didn't realized it. Also, I've here that exception highly hacked dumping everything to logs file. Sure that has not helped detecting the problem.

Thanks!

Show
Eloy Lafuente (stronk7) added a comment - crap, I remember perfectly I had to play with those params because there was something "extra" in moodle_exception. It seems the extra gone and I didn't realized it. Also, I've here that exception highly hacked dumping everything to logs file. Sure that has not helped detecting the problem. Thanks!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated!

Show
Eloy Lafuente (stronk7) added a comment - Integrated!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

tested by throwing manually one backup_step_exception and checking everything arrives / is displayed as expected.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - tested by throwing manually one backup_step_exception and checking everything arrives / is displayed as expected. Ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

If there is a will, there is a way, and you found it! Thanks!

Show
Eloy Lafuente (stronk7) added a comment - If there is a will, there is a way, and you found it! Thanks!

People

  • Assignee:
    Tim Hunt
    Reporter:
    Tim Hunt
    Peer reviewer:
    Eloy Lafuente (stronk7)
    Integrator:
    Eloy Lafuente (stronk7)
    Tester:
    Eloy Lafuente (stronk7)
    Participants:
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: