Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27827

Feedback: Missing messageprovider:message language string

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1
    • Fix Version/s: 2.0.4
    • Component/s: Feedback
    • Labels:

      Description

      /mod/feedback/db/message.php defines two message providers for the feedback module; however, the messageprovider:message is missing from the /mod/feedback/lang/en/feedback.php file. Based off of the comments in the message.php file I have created a string but it may need to be cleaned up.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            aborrow Anthony Borrow added a comment -

            adding to stable backlog

            Show
            aborrow Anthony Borrow added a comment - adding to stable backlog
            Show
            aborrow Anthony Borrow added a comment - Here is a possible patch - https://github.com/arborrow/moodle/compare/MOODLE_20_STABLE...MDL-27827
            Hide
            salvetore Michael de Raadt added a comment -

            Promoting this as it is related to a QA test.

            Show
            salvetore Michael de Raadt added a comment - Promoting this as it is related to a QA test.
            Hide
            grabs Andreas Grabs added a comment -

            sorry for the long duration

            Show
            grabs Andreas Grabs added a comment - sorry for the long duration
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Although this is related to MDLQA-1008 it's only tangentially, so it has been tested here. Works as expected (strings shown properly)

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Although this is related to MDLQA-1008 it's only tangentially, so it has been tested here. Works as expected (strings shown properly)
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Followup idea: anybody agreeing, please add it to new issue. The more options I get in the /message/edit.php page, the less clear what each option is. IMO we should implement some help system within that page explaining each messaging provider and when it gets fired.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Followup idea: anybody agreeing, please add it to new issue. The more options I get in the /message/edit.php page, the less clear what each option is. IMO we should implement some help system within that page explaining each messaging provider and when it gets fired. Ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Your awesome code is now part of the next Moodle release, congrats!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Your awesome code is now part of the next Moodle release, congrats!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Aug/11