Moodle
  1. Moodle
  2. MDL-27827

Feedback: Missing messageprovider:message language string

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1
    • Fix Version/s: 2.0.4
    • Component/s: Feedback
    • Labels:
    • Rank:
      17468

      Description

      /mod/feedback/db/message.php defines two message providers for the feedback module; however, the messageprovider:message is missing from the /mod/feedback/lang/en/feedback.php file. Based off of the comments in the message.php file I have created a string but it may need to be cleaned up.

        Issue Links

          Activity

          Hide
          Anthony Borrow added a comment -

          adding to stable backlog

          Show
          Anthony Borrow added a comment - adding to stable backlog
          Hide
          Anthony Borrow added a comment -
          Show
          Anthony Borrow added a comment - Here is a possible patch - https://github.com/arborrow/moodle/compare/MOODLE_20_STABLE...MDL-27827
          Hide
          Michael de Raadt added a comment -

          Promoting this as it is related to a QA test.

          Show
          Michael de Raadt added a comment - Promoting this as it is related to a QA test.
          Hide
          Andreas Grabs added a comment -

          sorry for the long duration

          Show
          Andreas Grabs added a comment - sorry for the long duration
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Although this is related to MDLQA-1008 it's only tangentially, so it has been tested here. Works as expected (strings shown properly)

          Show
          Eloy Lafuente (stronk7) added a comment - Although this is related to MDLQA-1008 it's only tangentially, so it has been tested here. Works as expected (strings shown properly)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Followup idea: anybody agreeing, please add it to new issue. The more options I get in the /message/edit.php page, the less clear what each option is. IMO we should implement some help system within that page explaining each messaging provider and when it gets fired.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Followup idea: anybody agreeing, please add it to new issue. The more options I get in the /message/edit.php page, the less clear what each option is. IMO we should implement some help system within that page explaining each messaging provider and when it gets fired. Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Your awesome code is now part of the next Moodle release, congrats!

          Show
          Eloy Lafuente (stronk7) added a comment - Your awesome code is now part of the next Moodle release, congrats!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: