Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27829

Pagetypes: Find a fix for core component and plugin overlaps before 2.1 release

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: Blocks
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      To test you need to add a block to a variety of pages then edit the block's settings and check the "display on page types" drop down. The set of options that should be available are listed below. The ordering of the options isn't important.

      on a course main page:
      any page
      any course page
      any type of course page

      on a quiz:
      any quiz module page
      edit quiz page

      on a database activity:
      no drop down as this is handle automatically.

      on a course report like the course activity report (Courses > course name > Reports > activity report):
      any page
      any course report
      just the current course report ie "Activity course report"

      on an admin setting page like Advanced features (Site administration > Advanced features):
      The current admin setting page
      Any admin setting page

      Show
      To test you need to add a block to a variety of pages then edit the block's settings and check the "display on page types" drop down. The set of options that should be available are listed below. The ordering of the options isn't important. on a course main page: any page any course page any type of course page on a quiz: any quiz module page edit quiz page on a database activity: no drop down as this is handle automatically. on a course report like the course activity report (Courses > course name > Reports > activity report): any page any course report just the current course report ie "Activity course report" on an admin setting page like Advanced features (Site administration > Advanced features): The current admin setting page Any admin setting page
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27829_block_pagetype_master
    • Pull Master Diff URL:

      Description

      Hi Andrew,

      As discussed just before MDL-26105 has been integrated with master now but before the release of 2.1 we need to find a solution for overlap problems arising from a crossover between core components and plugins.
      To test the problem add a block to a course report page - inspect the block_instance table, edit the block and look at the setting options (all course related) and after saving watch what happens to the block_instance table.
      While discussing it we wondered about the idea of allowing overriding callbacks built by looking at the raw pagetype.

      Yell out if you have any questions.

      Cheers
      Sam

        Attachments

          Issue Links

          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-27893 Check that the display page types in 2.1 are backwards compatible with 2.0.3

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-28149 Should we support power-users who want to use arbitrary pagetypepatterns for blocks?

          • Major - Major loss of function, incorrect output
          • Open

          Improvement - An enhancement to an existing Moodle feature. MDL-28150 Should all plugins, not just mods, have a callback to propose page-type patterns

          • Major - Major loss of function, incorrect output
          • Open
          will help resolve

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-26105 User friendly block settings and help information

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

            Activity

              People

              Assignee:
              andyjdavis Andrew Davis
              Reporter:
              samhemelryk Sam Hemelryk
              Peer reviewer:
              Sam Hemelryk
              Integrator:
              Sam Hemelryk
              Tester:
              Helen Foster
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                1/Jul/11