Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27842

Error displayed when deleting calendar event

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.2.2
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Events API
    • Labels:
    • Testing Instructions:
      Hide

      1. Ensure debugging is turned on at Site Administration -> Development -> Debugging
      2. Click on a ling in the calendar block to be taken to the list of events
      3. Click the button "New event" button
      4. Enter details for a new event and save
      5. Find the new event in the events list
      6. Click the X icon on the right of the event
      7. The event information should be shown without any errors reported

      Show
      1. Ensure debugging is turned on at Site Administration -> Development -> Debugging 2. Click on a ling in the calendar block to be taken to the list of events 3. Click the button "New event" button 4. Enter details for a new event and save 5. Find the new event in the events list 6. Click the X icon on the right of the event 7. The event information should be shown without any errors reported
    • Workaround:
      Hide

      Leave debugging off

      Show
      Leave debugging off
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE

      Description

      When deleting an event with debugging turned on, the following error is shown.

      calendar_print_event is deprecated please update your code
          line 558 of \calendar\lib.php: call to debugging()
          line 124 of \calendar\delete.php: call to calendar_print_event()

      Replication instructions:

      1. Ensure debugging is turned on at Site Administration -> Development -> Debugging
      2. Click on a ling in the calendar block to be taken to the list of events
      3. Click the button "New event" button
      4. Enter details for a new event and save
      5. Find the new event in the events list
      6. Click the X icon on the right of the event
      7. The event information is shown with an error

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              ankit_frenz Ankit Agarwal added a comment -

              Estimated development time:- 1 hour

              Show
              ankit_frenz Ankit Agarwal added a comment - Estimated development time:- 1 hour
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              This has been fixed in 23 onwards, just back porting the same changes to 2.2 and 2.1
              Thanks

              Show
              ankit_frenz Ankit Agarwal added a comment - This has been fixed in 23 onwards, just back porting the same changes to 2.2 and 2.1 Thanks
              Hide
              rwijaya Rossiani Wijaya added a comment -

              This looks good Ankit.

              +1 for submitting for integration review.

              Show
              rwijaya Rossiani Wijaya added a comment - This looks good Ankit. +1 for submitting for integration review.
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              Thanks for the review Rosie, sending for integration

              Show
              ankit_frenz Ankit Agarwal added a comment - Thanks for the review Rosie, sending for integration
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated, thanks Ankit

              Show
              poltawski Dan Poltawski added a comment - Integrated, thanks Ankit
              Hide
              andyjdavis Andrew Davis added a comment - - edited

              Works fine in 2.1, 2.2 and master. Raised MDL-34168 while testing.

              Show
              andyjdavis Andrew Davis added a comment - - edited Works fine in 2.1, 2.2 and master. Raised MDL-34168 while testing.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Congratulations your code is upstream - gold star for you!

              This issue + 79 others made it in in time for the minor releases.
              Thank you everyone involved for your exuberant efforts.

              Show
              samhemelryk Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Jul/12