[MDL-27845] News forum items with ratings report DB errors - Moodle Tracker

XML

Word

Printable

Database:

PostgreSQL
Testing Instructions:

Hide

1. set up a moodle site using postgresql as the database if you dont already have one
2. access a forum and submit a rating
3. check that the aggregate updates appropriately (assuming your use has the capabilities required to see the aggregate)

Show
1. set up a moodle site using postgresql as the database if you dont already have one 2. access a forum and submit a rating 3. check that the aggregate updates appropriately (assuming your use has the capabilities required to see the aggregate)
Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Fixed Branches:
MOODLE_21_STABLE
Pull from Repository:
git://github.com/andyjdavis/moodle.git
Pull Master Branch:
~~MDL-27845~~_rating_aggregation
Pull Master Diff URL:
https://github.com/andyjdavis/moodle/compare/master...MDL-27845_rating_aggregation

I got this error when access news forum: Debug info:

ERROR: column "ur.rating" must appear in the GROUP BY clause or be used in an aggregate function

LINE 3: ... ur.id, ur.userid, ur.scaleid, ur.rating ...

SELECT r.itemid, r.component, r.ratingarea, r.contextid,

AVG(r.rating) AS aggrrating, COUNT(r.rating) AS numratings,

ur.id, ur.userid, ur.scaleid, ur.rating AS usersrating

FROM mdl_rating r

LEFT JOIN mdl_rating ur ON ur.contextid = r.contextid AND

ur.itemid = r.itemid AND

ur.component = r.component AND

ur.ratingarea = r.ratingarea AND

ur.userid = $1

WHERE r.contextid = $2 AND

r.itemid = $3 AND

r.component = $4 AND

r.ratingarea = $5

GROUP BY r.itemid, r.component, r.ratingarea, r.contextid, ur.id, ur.userid, ur.scaleid

ORDER BY r.itemid

[array (

0 => '2',

1 => '28',

2 => '31',

3 => 'mod_forum',

4 => 'post',

)]

has been marked as being related by

MDL-28395 Error Reading from Database when one uses Ratings with Discussion Forum

MDL-28465 Split the get_ratings() query into two to avoid potential postgres aggregation problems

Participants:: Andrew Davis, Aparup Banerjee, Eloy Lafuente (stronk7), Michael de Raadt, Petr Skoda, Rajesh Taneja, Sam Hemelryk

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias