Moodle
  1. Moodle
  2. MDL-27855

"Users" link in "Breadcrumb" presents Student with error message

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.0.4, 2.1.1
    • Component/s: Navigation
    • Labels:
    • Rank:
      17540

      Description

      If a Student opens a course teacher's profile and views the details the "Breadcrumb" trail or navigation bar is something like:
      Home/ Users / TeachersName .
      The word Users is an active link that displays the error to the learner when clicked on:
      "Sorry, but you do not currently have permissions to do that (View participants)"

      The link should not be active and visible to user if an error will result in an error for the user.

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this.

        I verified the problem on Moodle 2.0.2+ and 2.1Dev.

        I've put it on our backlog and we'll try to get to it as soon as we can.

        In the meantime adding more information, such as replication instructions, fix test instructions, a workaround or even a code solution, will help us and other users.

        Show
        Michael de Raadt added a comment - Thanks for reporting this. I verified the problem on Moodle 2.0.2+ and 2.1Dev. I've put it on our backlog and we'll try to get to it as soon as we can. In the meantime adding more information, such as replication instructions, fix test instructions, a workaround or even a code solution, will help us and other users.
        Hide
        Dan Poltawski added a comment -

        Integrators: Should I be creating separate branches for the different stable versions even if the patch applies cleanly to 20_STABLE & 21_STABLE??

        Show
        Dan Poltawski added a comment - Integrators: Should I be creating separate branches for the different stable versions even if the patch applies cleanly to 20_STABLE & 21_STABLE??
        Hide
        Sam Hemelryk added a comment -

        Hi Dan, this has been integrated now.

        In regards to your question it is certainly appreciated if you do create separate branches for your work.

        With the small bugs you've put forward this week I've merged the branch you have created to master and then for MOODLE_20_STABLE and MOODLE_21_STABLE I've cherry-picked the commit.
        Certainly with larger patches (or multiple commits) we'll ask you create separate branches, and for the smaller ones it would be nice.
        No worries this week though

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi Dan, this has been integrated now. In regards to your question it is certainly appreciated if you do create separate branches for your work. With the small bugs you've put forward this week I've merged the branch you have created to master and then for MOODLE_20_STABLE and MOODLE_21_STABLE I've cherry-picked the commit. Certainly with larger patches (or multiple commits) we'll ask you create separate branches, and for the smaller ones it would be nice. No worries this week though Cheers Sam
        Hide
        Rajesh Taneja added a comment -

        Works Great
        Thanks for providing the patch Dan.

        Show
        Rajesh Taneja added a comment - Works Great Thanks for providing the patch Dan.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        If there is a will, there is a way, and you found it! Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - If there is a will, there is a way, and you found it! Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: