Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27862

Theme selector strings need updating and unset button required to unset theme

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Go to theme selector (Settings -> site administrator -> theme selector -> Select device)
      3. make sure navigation works fine and you can navigate to theme page and device selection page
      4. Check lang strings on change device and theme selection page (should match with description of bug, except button label)
      5. Change them on all devices and it should work fine
      6. remove theme on device and make sure theme can be unset on all devices (except default)
      Show
      Log in as admin Go to theme selector (Settings -> site administrator -> theme selector -> Select device) make sure navigation works fine and you can navigate to theme page and device selection page Check lang strings on change device and theme selection page (should match with description of bug, except button label) Change them on all devices and it should work fine remove theme on device and make sure theme can be unset on all devices (except default)
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-mdl-27862
    • Pull Master Diff URL:

      Description

      After changes made in MDL-25394, selecting a theme is now a two step process. First the user specifies a device, then they select a theme. This is not obvious now with the pre-existing strings.

      The following strings changes will make the process clearer.

      • First page title "Theme" -> "Select Device Type"
      • First page, table title "Theme" -> "Current theme" or "Current theme for device"
      • First page, button text "Select theme" -> "Select theme for device" (possibly too long)
      • Second page title "Themes" -> "Select theme for <device type>"
      • Second page, button text "Use theme" -> "Use theme for <device type>"

      As another improvement, the navigation menu could expand another level under "Theme Selector" with a sub-item for each device type.

      In addition to this:
      it's impossible to "un-select" themes for device types and perhaps it should be something to consider. Also, clear cache redirect to first page, should remain at the same page from where it is called.

        Attachments

        1. MDL-27862-DEFAULT.jpg
          MDL-27862-DEFAULT.jpg
          26 kB
        2. MDL-27862-DEVICETHEMES.jpg
          MDL-27862-DEVICETHEMES.jpg
          26 kB
        3. MDL-27862-LEGACY.jpg
          MDL-27862-LEGACY.jpg
          18 kB
        4. MDL-27862-MOBILE.jpg
          MDL-27862-MOBILE.jpg
          17 kB
        5. MDL-27862-TABLET.jpg
          MDL-27862-TABLET.jpg
          15 kB

          Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-25394 Improved Support for Mobile Themes and Browser Detection

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          has a non-specific relationship to

          Improvement - An enhancement to an existing Moodle feature. MDL-31927 Theme selector should be changed from 2-screen to 1-screen selection

          • Minor - Minor loss of function where workaround is possible
          • Open
          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-29552 Usability: Show the name of the selected theme for each device

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30952 New Theme selection in 2.1 incredibly confusing

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-28125 Text string change

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Improvement - An enhancement to an existing Moodle feature. MDL-23458 Very hard to see which is the currently selected theme in theme selector

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              rajeshtaneja Rajesh Taneja
              Reporter:
              salvetore Michael de Raadt
              Peer reviewer:
              Ankit Agarwal Ankit Agarwal
              Integrator:
              Aparup Banerjee Aparup Banerjee
              Tester:
              Michael de Raadt Michael de Raadt
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/12