Moodle
  1. Moodle
  2. MDL-27862

Theme selector strings need updating and unset button required to unset theme

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Go to theme selector (Settings -> site administrator -> theme selector -> Select device)
      3. make sure navigation works fine and you can navigate to theme page and device selection page
      4. Check lang strings on change device and theme selection page (should match with description of bug, except button label)
      5. Change them on all devices and it should work fine
      6. remove theme on device and make sure theme can be unset on all devices (except default)
      Show
      Log in as admin Go to theme selector (Settings -> site administrator -> theme selector -> Select device) make sure navigation works fine and you can navigate to theme page and device selection page Check lang strings on change device and theme selection page (should match with description of bug, except button label) Change them on all devices and it should work fine remove theme on device and make sure theme can be unset on all devices (except default)
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      wip-mdl-27862
    • Rank:
      17511

      Description

      After changes made in MDL-25394, selecting a theme is now a two step process. First the user specifies a device, then they select a theme. This is not obvious now with the pre-existing strings.

      The following strings changes will make the process clearer.

      • First page title "Theme" -> "Select Device Type"
      • First page, table title "Theme" -> "Current theme" or "Current theme for device"
      • First page, button text "Select theme" -> "Select theme for device" (possibly too long)
      • Second page title "Themes" -> "Select theme for <device type>"
      • Second page, button text "Use theme" -> "Use theme for <device type>"

      As another improvement, the navigation menu could expand another level under "Theme Selector" with a sub-item for each device type.

      In addition to this:
      it's impossible to "un-select" themes for device types and perhaps it should be something to consider. Also, clear cache redirect to first page, should remain at the same page from where it is called.

      1. MDL-27862-DEFAULT.jpg
        26 kB
      2. MDL-27862-DEVICETHEMES.jpg
        26 kB
      3. MDL-27862-LEGACY.jpg
        18 kB
      4. MDL-27862-MOBILE.jpg
        17 kB
      5. MDL-27862-TABLET.jpg
        15 kB

        Issue Links

          Activity

          Michael de Raadt created issue -
          Michael de Raadt made changes -
          Field Original Value New Value
          Link This issue blocks MDL-25394 [ MDL-25394 ]
          Michael de Raadt made changes -
          Fix Version/s STABLE backlog [ 10463 ]
          Priority Minor [ 4 ] Major [ 3 ]
          Labels triaged
          Michael de Raadt made changes -
          Link This issue is duplicated by MDL-28125 [ MDL-28125 ]
          Eloy Lafuente (stronk7) made changes -
          Link This issue has been marked as being related by MDL-29552 [ MDL-29552 ]
          Howard Miller made changes -
          Link This issue is duplicated by MDL-30952 [ MDL-30952 ]
          Michael de Raadt made changes -
          Priority Major [ 3 ] Critical [ 2 ]
          Mary Evans made changes -
          Assignee Patrick Malley [ ptrkmkl ] Rajesh Taneja [ rajeshtaneja ]
          Component/s Administration [ 10050 ]
          Component/s Themes [ 10088 ]
          Rajesh Taneja made changes -
          Fix Version/s STABLE Sprint 18 [ 11650 ]
          Fix Version/s STABLE backlog [ 10463 ]
          Rajesh Taneja made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Rajesh Taneja made changes -
          Pull Master Diff URL https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-27862
          Pull Master Branch wip-mdl-27862
          Pull from Repository git://github.com/rajeshtaneja/moodle.git
          Rajesh Taneja made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Rajesh Taneja made changes -
          Testing Instructions # Log in as admin
          # Go to theme selector (Settings -> site administrator -> theme selector -> Select device)
          # make sure navigation works fine and you can navigate to theme page and device selection page
          # Check lang strings on change device and theme selection page (should match with description of bug, except button label)
          # Change them on all devices and it should work fine
          # remove theme on device and make sure theme can be unset on all devices (except default)
          Ankit Agarwal made changes -
          Peer reviewer ankit_frenz
          Ankit Agarwal made changes -
          Original Estimate 0 minutes [ 0 ]
          Remaining Estimate 0 minutes [ 0 ]
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Rajesh Taneja made changes -
          Rajesh Taneja made changes -
          Status Peer review in progress [ 10013 ] Waiting for integration review [ 10010 ]
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Labels triaged triaged ui_change
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Reopened [ 4 ]
          Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          Rajesh Taneja made changes -
          Status Reopened [ 4 ] Development in progress [ 3 ]
          Rajesh Taneja made changes -
          Link This issue has a non-specific relationship to MDL-31927 [ MDL-31927 ]
          Rajesh Taneja made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Ankit Agarwal made changes -
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Ankit Agarwal made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          Mary Evans made changes -
          Attachment MDL-27862-DEFAULT.jpg [ 27250 ]
          Attachment MDL-27862-LEGACY.jpg [ 27251 ]
          Attachment MDL-27862-MOBILE.jpg [ 27252 ]
          Attachment MDL-27862-TABLET.jpg [ 27253 ]
          Attachment MDL-27862-DEVICETHEMES.jpg [ 27254 ]
          Rajesh Taneja made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Aparup Banerjee made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator nebgor
          Rajesh Taneja made changes -
          Summary Theme selector strings need updating to make them less confusing Theme selector strings need updating and unset button required to unset theme
          Description After changes made in MDL-25394, selecting a theme is now a two step process. First the user specifies a device, then they select a theme. This is not obvious now with the pre-existing strings.

          The following strings changes will make the process clearer.
           - First page title "Theme" -> "Select Device Type"
           - First page, table title "Theme" -> "Current theme" or "Current theme for device"
           - First page, button text "Select theme" -> "Select theme for device" (possibly too long)
           - Second page title "Themes" -> "Select theme for <device type>"
           - Second page, button text "Use theme" -> "Use theme for <device type>"

          As another improvement, the navigation menu could expand another level under "Theme Selector" with a sub-item for each device type.
          After changes made in MDL-25394, selecting a theme is now a two step process. First the user specifies a device, then they select a theme. This is not obvious now with the pre-existing strings.

          The following strings changes will make the process clearer.
           - First page title "Theme" -> "Select Device Type"
           - First page, table title "Theme" -> "Current theme" or "Current theme for device"
           - First page, button text "Select theme" -> "Select theme for device" (possibly too long)
           - Second page title "Themes" -> "Select theme for <device type>"
           - Second page, button text "Use theme" -> "Use theme for <device type>"

          As another improvement, the navigation menu could expand another level under "Theme Selector" with a sub-item for each device type.

          In addition to this:
          it's impossible to "un-select" themes for device types and perhaps it should be something to consider. Also, clear cache redirect to first page, should remain at the same page from where it is called.
          Aparup Banerjee made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.2.2 [ 11552 ]
          Affects Version/s 2.1.5 [ 11553 ]
          Affects Version/s 2.3 [ 10657 ]
          Affects Version/s 2.1 [ 10370 ]
          Fix Version/s 2.1.6 [ 12052 ]
          Fix Version/s 2.2.3 [ 12053 ]
          Michael de Raadt made changes -
          Tester salvetore
          Michael de Raadt made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Michael de Raadt made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 15/Mar/12
          Mary Evans made changes -
          Link This issue will help resolve MDL-23458 [ MDL-23458 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s STABLE Sprint 18 [ 11650 ]

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: