-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Deferred
-
Affects Version/s: 1.9.12, 2.0.3
-
Component/s: Libraries
-
Labels:
-
Environment:Mac and servers with different timezone then "Australia/Perth"
-
Testing Instructions:
-
Affected Branches:MOODLE_19_STABLE, MOODLE_20_STABLE
-
Fixed Branches:MOODLE_19_STABLE, MOODLE_20_STABLE
-
Pull from Repository:
-
Pull Master Branch:wip-mdl-27863-master
-
Pull Master Diff URL:
Eloy found out few issues in testcase for MDL-27577.
Issue 1:
I'm passing the test because it seems that the offset is properly calculated always... but I'm getting this errors in my Mac:
Expected: Friday, 1 July 2011, 10:00 AM => Actual: Friday, 1 July 2011, 10:00 am
So really tests aren't passing here, because my local return the AM/PM information lowercased.
Issue 2:
Some of the tests are only going to work in sites being Perth/Australia @ OS, because test results are dependent of that.
To be able to reproduce that, just add this line:
date_default_timezone_set('Europe/Madrid');
in the very fist lines of test_userdate() and you will get the offending ones.
I think they are the ones calculating based on server time. I get 4 errors here.
- has a non-specific relationship to
-
MDL-29001 Remove timezone test fixtures which depend on setting date_default_timezone_set('Australia/Perth');
-
- Closed
-
- has been marked as being related by
-
MDL-27577 /lib/moodlelib.php functions userdate() and make_timestamp() were applying dst_offset for numeric timezones, i.e. 0 (UTC)
-
- Closed
-