Hi Tim,

I got these while testing some of the other issues you've fixed.
If you create a calculated simple question using the values in the help page for this question type you can replicate the problem.

Creating a calculated simple question

Notice: Undefined property: qtype_calculatedsimple::$fileoptionsa in /var/git/integration/master/question/type/calculatedsimple/questiontype.php on line 109
Call Stack

1. Time Memory Function Location
   1 0.0013 888072
   Unknown macro: {main}

   ( ) ../question.php:0
   2 0.2397 45803064 qtype_calculated->save_question( ) ../question.php:264
   3 0.2397 45803280 question_type->save_question( ) ../questiontype.php:622
   4 0.3165 45878304 qtype_calculatedsimple->save_question_options( ) ../questiontypebase.php:424

   ( ! ) Warning: ksort() expects parameter 1 to be array, null given in /var/git/integration/master/question/type/calculatedsimple/questiontype.php on line 201
   Call Stack

   1. Time Memory Function Location
      1 0.0013 888072

   ( ) ../question.php:0
   2 0.2397 45803064 qtype_calculated->save_question( ) ../question.php:264
   3 0.2397 45803280 question_type->save_question( ) ../questiontype.php:622
   4 0.3165 45878304 qtype_calculatedsimple->save_question_options( ) ../questiontypebase.php:424
   5 0.5852 45999824 ksort ( ) ../questiontype.php:201

( ! ) Warning: Invalid argument supplied for foreach() in /var/git/integration/master/question/type/calculatedsimple/questiontype.php on line 202
Call Stack

1. Time Memory Function Location
   1 0.0013 888072
   Unknown macro: {main}

   ( ) ../question.php:0
   2 0.2397 45803064 qtype_calculated->save_question( ) ../question.php:264
   3 0.2397 45803280 question_type->save_question( ) ../questiontype.php:622
   4 0.3165 45878304 qtype_calculatedsimple->save_question_options( ) ../questiontypebase.php:424

I also suspect that there are further problems this causes if you then use the created question in a quiz and/or backup/restore/export/attempt to take the quiz etc..

Cheers
Sam