Moodle
  1. Moodle
  2. MDL-27867

Themes hidden from the theme selector are shown in the course/user/category theme dropdowns as selectable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.1
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Make sure that the settings allowuserthemes, allowcoursethemes, and allowcategorythemes are turned on.
      3. Edit a course and make sure that base and canvas don't show in the theme selector
      4. Edit a category and make sure that base and canvas don't show in the theme selector
      5. Edit a user and make sure that base and canvas don't show in the theme selector
      Show
      Log in as an admin Make sure that the settings allowuserthemes, allowcoursethemes, and allowcategorythemes are turned on. Edit a course and make sure that base and canvas don't show in the theme selector Edit a category and make sure that base and canvas don't show in the theme selector Edit a user and make sure that base and canvas don't show in the theme selector
    • Workaround:
      Hide

      See the linked forum post for a good work around.

      Show
      See the linked forum post for a good work around.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Rank:
      17570

      Description

      See the linked forum for the original post.
      This is a really a bug - unless theme designer mode is turned on themes that have chosen to hide themselves from the theme selector should also be hidden from these drop downs.

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Linking to MDL-28599 which fixed this issue in master.

          Show
          Sam Hemelryk added a comment - Linking to MDL-28599 which fixed this issue in master.
          Hide
          Sam Hemelryk added a comment -

          This was already fixed in master by MDL-28599 (which made a few other cool changes as well).
          The changes I've put forward fix this specific issue in 20 and 21.
          Easy fix (partial backport of MDL-28599) and easy to test

          Show
          Sam Hemelryk added a comment - This was already fixed in master by MDL-28599 (which made a few other cool changes as well). The changes I've put forward fix this specific issue in 20 and 21. Easy fix (partial backport of MDL-28599 ) and easy to test
          Hide
          Aparup Banerjee added a comment -

          Integrated and up for testing.

          Show
          Aparup Banerjee added a comment - Integrated and up for testing.
          Hide
          Rossiani Wijaya added a comment -

          Thanks for fixing this Sam.

          It look great.

          Test passed.

          Show
          Rossiani Wijaya added a comment - Thanks for fixing this Sam. It look great. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          git repositories have been updated with your awesome changes, thanks! Closing.

          Show
          Eloy Lafuente (stronk7) added a comment - git repositories have been updated with your awesome changes, thanks! Closing.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: