Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27876

SCORM Player height not adjustable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      Enter a SCORM package and modify Browser height while viewing SCORM and make sure Stage resizes to allow use of full height of browser. (best to do on a big screen!)

      Good to test in a range of browsers if poss - I've tested:
      Windows: IE7, FF 5
      Ubuntu: FF 5

      Show
      Enter a SCORM package and modify Browser height while viewing SCORM and make sure Stage resizes to allow use of full height of browser. (best to do on a big screen!) Good to test in a range of browsers if poss - I've tested: Windows: IE7, FF 5 Ubuntu: FF 5
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
      master_MDL-27876

      Description

      Whilst the width of the SCORM player works well and adjusts to different width settings, the height of the SCORM player does not. Instead it creates a vertical scroll bar, causing the user to have to constantly scroll, top to bottom and visa versa, in order to see the contents.

      See forum discussion: http://moodle.org/mod/forum/discuss.php?d=177174#p778695

        Gliffy Diagrams

          Issue Links

            Activity

            lazydaisy Mary Evans created issue -
            danmarsden Dan Marsden made changes -
            Field Original Value New Value
            Fix Version/s STABLE backlog [ 10463 ]
            Labels triaged
            Hide
            lazydaisy Mary Evans added a comment -

            Hi Dan,t
            A client of mine, who is experiencing a lot of problems with SCORM mainly with the height of the frame, is asking what the timeline for coming up with a patch is likly to be? Any likelyhood of this being incorporated into Moodle 2.1.1 Dan? Or are we looking at a long wait?

            Cheers
            Mary

            Show
            lazydaisy Mary Evans added a comment - Hi Dan,t A client of mine, who is experiencing a lot of problems with SCORM mainly with the height of the frame, is asking what the timeline for coming up with a patch is likly to be? Any likelyhood of this being incorporated into Moodle 2.1.1 Dan? Or are we looking at a long wait? Cheers Mary
            lazydaisy Mary Evans made changes -
            Priority Minor [ 4 ] Blocker [ 1 ]
            Hide
            danmarsden Dan Marsden added a comment -

            Hi Mary,

            I'm about to take some leave over the next few weeks but I'll try to take a look sometime this week - if I don't manage to take a look this week then it won't be until at least mid August before i get a chance to look at it again.

            of course - if your client was willing to fund the time to look at the issue it might happen faster.

            Show
            danmarsden Dan Marsden added a comment - Hi Mary, I'm about to take some leave over the next few weeks but I'll try to take a look sometime this week - if I don't manage to take a look this week then it won't be until at least mid August before i get a chance to look at it again. of course - if your client was willing to fund the time to look at the issue it might happen faster.
            danmarsden Dan Marsden made changes -
            Priority Blocker [ 1 ] Critical [ 2 ]
            Hide
            danmarsden Dan Marsden added a comment -

            btw - there are probably at least 2 other issues I'll be looking at before this one - see this list for the issues on the stable backlog:
            http://tracker.moodle.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+MDL+AND+component+%3D+SCORM+AND+resolution+%3D+Unresolved+AND+fixVersion+%3D+%22STABLE+backlog%22+ORDER+BY+priority+DESC

            Show
            danmarsden Dan Marsden added a comment - btw - there are probably at least 2 other issues I'll be looking at before this one - see this list for the issues on the stable backlog: http://tracker.moodle.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+MDL+AND+component+%3D+SCORM+AND+resolution+%3D+Unresolved+AND+fixVersion+%3D+%22STABLE+backlog%22+ORDER+BY+priority+DESC
            danmarsden Dan Marsden made changes -
            Link This issue blocks MDL-28295 [ MDL-28295 ]
            Hide
            danmarsden Dan Marsden added a comment -

            also - if you're wanting to do this at a site wide level in the interim you could change this var in scorm/module.js:
            minHeight: 600,

            to something like:
            minHeight: 1200,

            Show
            danmarsden Dan Marsden added a comment - also - if you're wanting to do this at a site wide level in the interim you could change this var in scorm/module.js: minHeight: 600, to something like: minHeight: 1200,
            Hide
            lazydaisy Mary Evans added a comment -

            Thanks for this Dan...this might just be the fix I'm looking for.

            Show
            lazydaisy Mary Evans added a comment - Thanks for this Dan...this might just be the fix I'm looking for.
            Hide
            danmarsden Dan Marsden added a comment -

            I've just been looking at MDL-26482 and I wonder if the TOC is disabled we should strip the player out and just embed the SCORM in a standard object without the fancy player?

            Show
            danmarsden Dan Marsden added a comment - I've just been looking at MDL-26482 and I wonder if the TOC is disabled we should strip the player out and just embed the SCORM in a standard object without the fancy player?
            Hide
            lazydaisy Mary Evans added a comment -

            What you are suggesting sounds like a better idea. However, the fix you gave earlier is working great...the player displays to its full hight as required. The problem now is the Moodle custom-menu with its drop-down menu items, where each level of the drop-down menu has its own z-index value. But no matter what value you give it, even a billion will not get above the player.

            I have read it's the way it's embedded in the page. Is this correct, and if so is there a way to allow the custom menu to drop-down over the SCORM player?

            A fix for this has been suggested on this web page http://slightlymore.co.uk/flash-and-the-z-index-problem-solved/ which suggests that by adding an extra parameter in the code one uses to embed a file...<param name="wmode" value="opaque" /> it changes the way the flash object is embedded.

            It's all way above me all this sort of talk...so any advice...help...would be great.

            Cheers
            Mary

            Show
            lazydaisy Mary Evans added a comment - What you are suggesting sounds like a better idea. However, the fix you gave earlier is working great...the player displays to its full hight as required. The problem now is the Moodle custom-menu with its drop-down menu items, where each level of the drop-down menu has its own z-index value. But no matter what value you give it, even a billion will not get above the player. I have read it's the way it's embedded in the page. Is this correct, and if so is there a way to allow the custom menu to drop-down over the SCORM player? A fix for this has been suggested on this web page http://slightlymore.co.uk/flash-and-the-z-index-problem-solved/ which suggests that by adding an extra parameter in the code one uses to embed a file...<param name="wmode" value="opaque" /> it changes the way the flash object is embedded. It's all way above me all this sort of talk...so any advice...help...would be great. Cheers Mary
            Hide
            danmarsden Dan Marsden added a comment -

            unfortuantely you'll need to add that to the code inside your SCORM package - The SCORM player doesn't any flash but a lot of the packages do... Let me know if you find another method that involves changing the code in the player and I'd be happy to include it.

            thanks,

            Dan

            Show
            danmarsden Dan Marsden added a comment - unfortuantely you'll need to add that to the code inside your SCORM package - The SCORM player doesn't any flash but a lot of the packages do... Let me know if you find another method that involves changing the code in the player and I'd be happy to include it. thanks, Dan
            Hide
            danmarsden Dan Marsden added a comment -

            Thanks to Piers who took a look at this and put together this patch!!!!

            Show
            danmarsden Dan Marsden added a comment - Thanks to Piers who took a look at this and put together this patch!!!!
            danmarsden Dan Marsden made changes -
            Status Open [ 1 ] Waiting for integration review [ 10010 ]
            Pull Master Diff URL https://github.com/danmarsden/moodle/compare/master...master_MDL-27876
            Pull Master Branch master_MDL-27876
            Pull 2.0 Diff URL https://github.com/danmarsden/moodle/compare/MOODLE_20_STABLE...m20_MDL-27876
            Pull from Repository git://github.com/danmarsden/moodle.git
            Pull 2.0 Branch m20_MDL-27876
            Testing Instructions Enter a SCORM package and modify Browser height while viewing SCORM and make sure Stage resizes to allow use of full height of browser. (best to do on a big screen!)
            Pull 2.1 Branch m21_MDL-27876
            Pull 2.1 Diff URL https://github.com/danmarsden/moodle/compare/MOODLE_21_STABLE...m21_MDL-27876
            danmarsden Dan Marsden made changes -
            Testing Instructions Enter a SCORM package and modify Browser height while viewing SCORM and make sure Stage resizes to allow use of full height of browser. (best to do on a big screen!) Enter a SCORM package and modify Browser height while viewing SCORM and make sure Stage resizes to allow use of full height of browser. (best to do on a big screen!)

            Good to test in a range of browsers if poss - I've tested:
            Windows: IE7, FF 5
            Ubuntu: FF 5
            skodak Petr Skoda made changes -
            Currently in integration Yes
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi guys,
            Thanks for the great work on this so far. I'm sending this back around so that the height guessing code there can be improved.
            I see that the JS script already has access to the YUI2 libraries so certainly using something like the following would be a win for cross browser compatibility.

            YAHOO.util.Dom.getViewportWidth();
            YAHOO.util.Dom.getViewportHeight();

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi guys, Thanks for the great work on this so far. I'm sending this back around so that the height guessing code there can be improved. I see that the JS script already has access to the YUI2 libraries so certainly using something like the following would be a win for cross browser compatibility. YAHOO.util.Dom.getViewportWidth(); YAHOO.util.Dom.getViewportHeight(); Cheers Sam
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Reopened [ 4 ]
            Hide
            danmarsden Dan Marsden added a comment -

            hmmm - do you have time to test a new patch Sam? - I've already spent too much time on this and it's all non-chargeable work at this stage... Holding this patch back also means the more critical issue MDL-28295 can't go in.

            Show
            danmarsden Dan Marsden added a comment - hmmm - do you have time to test a new patch Sam? - I've already spent too much time on this and it's all non-chargeable work at this stage... Holding this patch back also means the more critical issue MDL-28295 can't go in.
            Hide
            danmarsden Dan Marsden added a comment -

            I've asked Piers if he has time to take another look.... but I'd really like to get this and MDL-28295 in this week.

            Show
            danmarsden Dan Marsden added a comment - I've asked Piers if he has time to take another look.... but I'd really like to get this and MDL-28295 in this week.
            Hide
            danmarsden Dan Marsden added a comment -

            Piers had some time!
            https://github.com/piersharding/moodle/commit/00c53985a82c238f7e8d436b8cdb2268bb4de138

            I'll fix the branches above and resubmit now.

            Show
            danmarsden Dan Marsden added a comment - Piers had some time! https://github.com/piersharding/moodle/commit/00c53985a82c238f7e8d436b8cdb2268bb4de138 I'll fix the branches above and resubmit now.
            Hide
            danmarsden Dan Marsden added a comment -

            updated code from Piers - thanks Piers!

            Show
            danmarsden Dan Marsden added a comment - updated code from Piers - thanks Piers!
            danmarsden Dan Marsden made changes -
            Status Reopened [ 4 ] Waiting for integration review [ 10010 ]
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks guys for getting that tidied up, its now been integrated. Cheers Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks guys for getting that tidied up, its now been integrated. Cheers Sam
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Hide
            danmarsden Dan Marsden added a comment -

            thank Sam!

            Show
            danmarsden Dan Marsden added a comment - thank Sam!
            skodak Petr Skoda made changes -
            Fix Version/s 2.0.5 [ 10950 ]
            Fix Version/s 2.1.2 [ 10851 ]
            Fix Version/s STABLE backlog [ 10463 ]
            mudrd8mz David Mudrak made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester mudrd8mz
            Hide
            mudrd8mz David Mudrak added a comment -

            Tested on Gentoo FF 5.0 and Chromium 12.0. Works well - the player adjusts the height as the window resizes. I just had to force reload to clear old JS from the local browser cache. Which is a bit weird as I expected the javascript revision is increased and the file reloaded automatically. Maybe it is because the version of mod_scorm was not increased?

            Show
            mudrd8mz David Mudrak added a comment - Tested on Gentoo FF 5.0 and Chromium 12.0. Works well - the player adjusts the height as the window resizes. I just had to force reload to clear old JS from the local browser cache. Which is a bit weird as I expected the javascript revision is increased and the file reloaded automatically. Maybe it is because the version of mod_scorm was not increased?
            mudrd8mz David Mudrak made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            skodak Petr Skoda made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes
            Integration date 3/Aug/11
            Hide
            jan0sch Jens Jahnke added a comment -

            I still have the issue that my scorm content only is displayed within a 400px height div.

            Show
            jan0sch Jens Jahnke added a comment - I still have the issue that my scorm content only is displayed within a 400px height div.
            Hide
            danmarsden Dan Marsden added a comment -

            Jens - please ask for help in the community forums - height can be controlled by a number of different things - the SCORM player in latest 2.xstable branches is designed to use the max space available by the browser and Moodle Theme.

            If you aren't using the latest stable 2.x release, please upgrade before you ask for help.
            If you are using a custom theme - please try using a standard one to see if it makes any difference.
            Check your SCORM package itself to make sure it isn't limiting the height by itself.
            Read this FAQ before asking for help in the forums:
            http://docs.moodle.org/20/en/SCORM_FAQ#Asking_for_Help_in_the_SCORM_Forum

            Show
            danmarsden Dan Marsden added a comment - Jens - please ask for help in the community forums - height can be controlled by a number of different things - the SCORM player in latest 2.xstable branches is designed to use the max space available by the browser and Moodle Theme. If you aren't using the latest stable 2.x release, please upgrade before you ask for help. If you are using a custom theme - please try using a standard one to see if it makes any difference. Check your SCORM package itself to make sure it isn't limiting the height by itself. Read this FAQ before asking for help in the forums: http://docs.moodle.org/20/en/SCORM_FAQ#Asking_for_Help_in_the_SCORM_Forum

              People

              • Votes:
                3 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Oct/11