Moodle
  1. Moodle
  2. MDL-27884

Tags block title text box is labelled "Tags"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.3.3, 2.4
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: Blocks
    • Labels:

      Description

      If you edit the settings of a tags blog the text box that controls its display title has "Tags" next to it for some reason. Probably just asking for the wrong string.

        Gliffy Diagrams

          Activity

          Hide
          Rossiani Wijaya added a comment -

          Reviewed this on 2.2, 2.3 and 2.4.

          Review list:
          [y] Syntax
          [y] Output
          [y] Whitespace
          [y] Language
          [-] Databases
          [-] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check - yes Ankit still sane

          Hi Ankit,

          The changes is fine, however you need to add amos script as part of your commit comment.

          Show
          Rossiani Wijaya added a comment - Reviewed this on 2.2, 2.3 and 2.4. Review list: [y] Syntax [y] Output [y] Whitespace [y] Language [-] Databases [-] Testing [-] Security [-] Documentation [y] Git [y] Sanity check - yes Ankit still sane Hi Ankit, The changes is fine, however you need to add amos script as part of your commit comment.
          Hide
          Ankit Agarwal added a comment -

          Added amos , submitting for integration
          Thanks

          Show
          Ankit Agarwal added a comment - Added amos , submitting for integration Thanks
          Hide
          Dan Poltawski added a comment -

          Urm, what is wrong with the Tags blog default title being 'tags'?

          Show
          Dan Poltawski added a comment - Urm, what is wrong with the Tags blog default title being 'tags'?
          Hide
          Ankit Agarwal added a comment -

          It is not for the default value, it the label for the title field itself which is called tags.

          Show
          Ankit Agarwal added a comment - It is not for the default value, it the label for the title field itself which is called tags.
          Hide
          Dan Poltawski added a comment -

          Ahha!

          Integrated, thanks!

          Show
          Dan Poltawski added a comment - Ahha! Integrated, thanks!
          Hide
          Frédéric Massart added a comment -

          Test passed on 2.3 onwards. Thanks!

          Show
          Frédéric Massart added a comment - Test passed on 2.3 onwards. Thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And your fantastic code has met core, hope they become good friends for a long period.

          Closing, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - And your fantastic code has met core, hope they become good friends for a long period. Closing, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: