Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0.4, 2.1, 2.2
-
Component/s: HTML Editor (TinyMCE)
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
-
Fixed Branches:MOODLE_20_STABLE, MOODLE_21_STABLE
-
Pull from Repository:
-
Pull Master Branch:wip-mdl-27896
-
Pull Master Diff URL:
Description
While integrating MDL-27500 and playing with new code was detected that the course->summary editor was not observing the filters status for the course context, causing the emoticons button (tinymce plugin) to be shown / hidden incorrectly.
After a nice trace session with David, it seems that we need to:
1) Add the missing 'context' element to the editoroptions array in course/edit.php
And also we have agreed it would be great to have some central check in order to find anomalous situations like that, so we have decided to:
2) Modify file_prepare_editor() (not used in all forms but in a hight %, and it's the only central point where both $options and $context are available) to:
2a) missing both OK
2b) $context !== $options['context'] then EXCEPTION
2c) missing one of them DEBUGGING_DEVELOPER