Moodle
  1. Moodle
  2. MDL-27922

Wrong string use in lesson view "link to activity"

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Blocker Blocker
        • Resolution: Fixed
        • Affects Version/s: 2.0
        • Fix Version/s: 2.1
        • Component/s: Lesson
        • Labels:
        • Workaround:
          Hide

          Bug fix:
          in file lesson.view, around line 1774, public function link_for_activitylink()
          replace:
          return html_writer::link(new moodle_url('/mod/'.$modname.'/view.php', array('id'=>$this->properties->activitylink)),
          get_string('returnto', 'lesson', get_string('activitylinkname', 'lesson', $instancename)),
          array('class'=>'centerpadded lessonbutton standardbutton'));

          with:

          return html_writer::link(new moodle_url('/mod/'.$modname.'/view.php', array('id'=>$this->properties->activitylink)),
          get_string('activitylinkname', 'lesson', $instancename),
          array('class'=>'centerpadded lessonbutton standardbutton'));

          Show
          Bug fix: in file lesson.view, around line 1774, public function link_for_activitylink() replace: return html_writer::link(new moodle_url('/mod/'.$modname.'/view.php', array('id'=>$this->properties->activitylink)), get_string('returnto', 'lesson', get_string('activitylinkname', 'lesson', $instancename)), array('class'=>'centerpadded lessonbutton standardbutton')); with: return html_writer::link(new moodle_url('/mod/'.$modname.'/view.php', array('id'=>$this->properties->activitylink)), get_string('activitylinkname', 'lesson', $instancename), array('class'=>'centerpadded lessonbutton standardbutton'));
        • Difficulty:
          Easy
        • Affected Branches:
          MOODLE_20_STABLE
        • Fixed Branches:
          MOODLE_21_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-27922_HEAD
        • Pull Master Diff URL:

          Description

          Wrong string use in lesson view "link to activity".
          At the end of a lesson, the link to activity displays:
          Return to Go to Activity link
          should be simply:
          Go to Activity link

          Ref. http://moodle.org/mod/forum/discuss.php?d=172173#p770686

            Gliffy Diagrams

              Issue Links

              has a non-specific relationship to

              Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27955 Error on navigating back through a lesson activity (reviewing lesson)

              • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
              • Closed
              will help resolve

              Functional Test - A test of a single Moodle feature MDLQA-1021 CLONE - A teacher can allow students to navigate back through a lesson activity

              • Passed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Michael de Raadt added a comment -

                Thanks for reporting this.

                I've put it on our backlog and we'll try to get to it as soon as we can.

                Show
                Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can.
                Hide
                Permalink
                Michael de Raadt added a comment -

                I just realised this was related to a QA test.

                Show
                Michael de Raadt added a comment - I just realised this was related to a QA test.
                Hide
                Permalink
                Rossiani Wijaya added a comment -

                Thanks Joseph for reporting.

                Github diff url is available above.

                Note: The above patches only fixed the string issue. It won't fix the main bug stated at MDLQA-1021. I will create new issue for that (if it hasn't exist).

                Show
                Rossiani Wijaya added a comment - Thanks Joseph for reporting. Github diff url is available above. Note: The above patches only fixed the string issue. It won't fix the main bug stated at MDLQA-1021 . I will create new issue for that (if it hasn't exist).
                Hide
                Permalink
                Michael de Raadt added a comment -

                Hi, Rosie.

                Thanks for working on this.

                When you create a new issue, be sure to link it back to MDLQA-1021 so we can reset the test when the bug is fixed.

                Michael;

                Show
                Michael de Raadt added a comment - Hi, Rosie. Thanks for working on this. When you create a new issue, be sure to link it back to MDLQA-1021 so we can reset the test when the bug is fixed. Michael;
                Hide
                Permalink
                Joseph Rézeau added a comment -

                Michael When you create a new issue, be sure to link it back to MDLQA-1021 so we can reset the test when the bug is fixed.
                Yes, sorry I forgot to do that. And thanks for the fix.

                Show
                Joseph Rézeau added a comment - Michael When you create a new issue, be sure to link it back to MDLQA-1021 so we can reset the test when the bug is fixed. Yes, sorry I forgot to do that. And thanks for the fix.
                Hide
                Permalink
                Rajesh Taneja added a comment -

                Hi! Rosie,

                Looks Great to me
                It will be nice to remove ":" from activitylinkname. Make it Go to {$a} from Go to: {$a}.

                +1 from me...

                Cheers
                Rajesh

                Show
                Rajesh Taneja added a comment - Hi! Rosie, Looks Great to me It will be nice to remove ":" from activitylinkname. Make it Go to {$a} from Go to: {$a}. +1 from me... Cheers Rajesh
                Hide
                Permalink
                Rajesh Taneja added a comment -

                Works Great

                Show
                Rajesh Taneja added a comment - Works Great
                Hide
                Permalink
                Rossiani Wijaya added a comment -

                Thanks Raj for reviewing.

                Note: have office discussion with Raj and Michael, we decided to remove the ":" from the string.

                submitting to integration.

                Show
                Rossiani Wijaya added a comment - Thanks Raj for reviewing. Note: have office discussion with Raj and Michael, we decided to remove the ":" from the string. submitting to integration.
                Hide
                Permalink
                Joseph Rézeau added a comment -

                Rajesh Taneja added a comment - 24/Jun/11 3:32 PM
                It will be nice to remove ":" from activitylinkname. Make it Go to {$a} from Go to: {$a}.
                I agree with the suggested removal, especially since the typograhical environment of the colon varies according to languages. For instance, in French, the colon must be preceded by an non-break space!

                Show
                Joseph Rézeau added a comment - Rajesh Taneja added a comment - 24/Jun/11 3:32 PM It will be nice to remove ":" from activitylinkname. Make it Go to {$a} from Go to: {$a}. I agree with the suggested removal, especially since the typograhical environment of the colon varies according to languages. For instance, in French, the colon must be preceded by an non-break space!
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Integrated, thanks!

                Show
                Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Passed, link text shown as expected.

                Note: This WILL NOT reset MDLQA-1021. MDL-27955 will.

                Show
                Eloy Lafuente (stronk7) added a comment - Passed, link text shown as expected. Note: This WILL NOT reset MDLQA-1021 . MDL-27955 will.
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Moode is now, for sure, a bit better thanks to you! This fix is now upstream.

                Show
                Eloy Lafuente (stronk7) added a comment - Moode is now, for sure, a bit better thanks to you! This fix is now upstream.

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: