Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27922

Wrong string use in lesson view "link to activity"

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 2.0
    • 2.1
    • Lesson
    • MOODLE_20_STABLE
    • MOODLE_21_STABLE
    • MDL-27922_HEAD
    • Hide

      Bug fix:
      in file lesson.view, around line 1774, public function link_for_activitylink()
      replace:
      return html_writer::link(new moodle_url('/mod/'.$modname.'/view.php', array('id'=>$this->properties->activitylink)),
      get_string('returnto', 'lesson', get_string('activitylinkname', 'lesson', $instancename)),
      array('class'=>'centerpadded lessonbutton standardbutton'));

      with:

      return html_writer::link(new moodle_url('/mod/'.$modname.'/view.php', array('id'=>$this->properties->activitylink)),
      get_string('activitylinkname', 'lesson', $instancename),
      array('class'=>'centerpadded lessonbutton standardbutton'));

      Show
      Bug fix: in file lesson.view, around line 1774, public function link_for_activitylink() replace: return html_writer::link(new moodle_url('/mod/'.$modname.'/view.php', array('id'=>$this->properties->activitylink)), get_string('returnto', 'lesson', get_string('activitylinkname', 'lesson', $instancename)), array('class'=>'centerpadded lessonbutton standardbutton')); with: return html_writer::link(new moodle_url('/mod/'.$modname.'/view.php', array('id'=>$this->properties->activitylink)), get_string('activitylinkname', 'lesson', $instancename), array('class'=>'centerpadded lessonbutton standardbutton'));
    • Easy

    Description

      Wrong string use in lesson view "link to activity".
      At the end of a lesson, the link to activity displays:
      Return to Go to Activity link
      should be simply:
      Go to Activity link

      Ref. http://moodle.org/mod/forum/discuss.php?d=172173#p770686

      Attachments

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27955 Error on navigating back through a lesson activity (reviewing lesson)

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          will help resolve

          Functional Test - A test of a single Moodle feature MDLQA-1021 CLONE - A teacher can allow students to navigate back through a lesson activity

          • Passed

          Activity

            People

              rwijaya Rossiani Wijaya
              rezeau Joseph Rézeau
              Rajesh Taneja Rajesh Taneja
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                1/Jul/11