Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27922

Wrong string use in lesson view "link to activity"

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.1
    • Component/s: Lesson
    • Labels:
    • Workaround:
      Hide

      Bug fix:
      in file lesson.view, around line 1774, public function link_for_activitylink()
      replace:
      return html_writer::link(new moodle_url('/mod/'.$modname.'/view.php', array('id'=>$this->properties->activitylink)),
      get_string('returnto', 'lesson', get_string('activitylinkname', 'lesson', $instancename)),
      array('class'=>'centerpadded lessonbutton standardbutton'));

      with:

      return html_writer::link(new moodle_url('/mod/'.$modname.'/view.php', array('id'=>$this->properties->activitylink)),
      get_string('activitylinkname', 'lesson', $instancename),
      array('class'=>'centerpadded lessonbutton standardbutton'));

      Show
      Bug fix: in file lesson.view, around line 1774, public function link_for_activitylink() replace: return html_writer::link(new moodle_url('/mod/'.$modname.'/view.php', array('id'=>$this->properties->activitylink)), get_string('returnto', 'lesson', get_string('activitylinkname', 'lesson', $instancename)), array('class'=>'centerpadded lessonbutton standardbutton')); with: return html_writer::link(new moodle_url('/mod/'.$modname.'/view.php', array('id'=>$this->properties->activitylink)), get_string('activitylinkname', 'lesson', $instancename), array('class'=>'centerpadded lessonbutton standardbutton'));
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27922_HEAD
    • Pull Master Diff URL:

      Description

      Wrong string use in lesson view "link to activity".
      At the end of a lesson, the link to activity displays:
      Return to Go to Activity link
      should be simply:
      Go to Activity link

      Ref. http://moodle.org/mod/forum/discuss.php?d=172173#p770686

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27955 Error on navigating back through a lesson activity (reviewing lesson)

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          will help resolve

          Functional Test - A test of a single Moodle feature MDLQA-1021 CLONE - A teacher can allow students to navigate back through a lesson activity

          • Passed

            Activity

              People

              Assignee:
              rwijaya Rossiani Wijaya
              Reporter:
              rezeau Joseph Rézeau
              Peer reviewer:
              Rajesh Taneja Rajesh Taneja
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                1/Jul/11