Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27931

In bulk user upload, city is required but not marked as required

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.9.13, 2.0.3, 2.1, 2.2
    • 2.0.4, 2.1.1
    • Administration
    • Any
    • Any
    • MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • MOODLE_20_STABLE, MOODLE_21_STABLE
    • Easy
    • Hide

      1. login as admin
      2. from side blocks, site admin > users > accounts > upload users
      3. upload user cvs file (file is attached)
      4. make sure city field is empty

      required error should appear on city field.

      Show
      1. login as admin 2. from side blocks, site admin > users > accounts > upload users 3. upload user cvs file (file is attached) 4. make sure city field is empty required error should appear on city field.

    Description

      In uploaduser_form.php the city field is required but not marked as such in the form. It's possible, though unlikely, to run across a use case where there isn't a default value that gets filled in for city, and in any case marking it as required is just best practice.

      Fix for 2.1: https://github.com/mackensen/moodle/commit/116fc1a0f2ba9326500ad8ad42d8548e72f80079

      Attachments

        Issue Links

          Activity

            People

              rwijaya Rossiani Wijaya
              cfulton Charles Fulton
              Aparup Banerjee Aparup Banerjee
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Marina Glancy Marina Glancy
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              12 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                1/Aug/11