[MDL-27932] Review and fix uses of quiz_feedback_for_grade() - Moodle Tracker

Details

Testing Instructions:

Hide

Logged as student with some attempt done, the notice above isn't shown.

Show
Logged as student with some attempt done, the notice above isn't shown.
Affected Branches:
MOODLE_21_STABLE
Fixed Branches:
MOODLE_21_STABLE
Pull from Repository:
git://github.com/stronk7/moodle.git
Pull Master Branch:
quiz_feedback_for_grade
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/master...quiz_feedback_for_grade

While reviewing I ended with this notice:

Notice: Undefined variable: cm in /Users/stronk7/git_moodle/moodle/mod/quiz/renderer.php on line 761

Tracing down the problem, I detected 3 incorrect uses of the quiz_feedback_for_grade() function. Fixing them make the problem disappear

Hide

Permalink

Sam Hemelryk added a comment - 20/Jun/11 1:04 PM

Thanks Eloy - integrated now

Show

Sam Hemelryk added a comment - 20/Jun/11 1:04 PM Thanks Eloy - integrated now

Hide

Permalink

Tim Hunt added a comment - 20/Jun/11 2:38 PM

Thanks, +1 from me too!

Show

Tim Hunt added a comment - 20/Jun/11 2:38 PM Thanks, +1 from me too!

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 21/Jun/11 12:20 AM

What can I say, passed.

Show

Eloy Lafuente (stronk7) added a comment - 21/Jun/11 12:20 AM What can I say, passed.

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 21/Jun/11 8:49 AM

U.P.S.T.R.E.A.M

Show

Eloy Lafuente (stronk7) added a comment - 21/Jun/11 8:49 AM U.P.S.T.R.E.A.M