[MDL-27952] quiz_extend_settings_navigation() failing for users having 0 options in activity settings - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_21_STABLE
Fixed Branches:
MOODLE_21_STABLE
Pull from Repository:
git://github.com/stronk7/moodle.git
Pull Master Branch:
~~MDL-27952~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/commit/1b8655ab0f51c12395c96bfe904cb24fcb26e4a4
Testing Instructions:
Hide

Debug enabled toDEVELOPER

Login as student and go to quiz/view.php page

TEST: No notices/warnings are shown

TEST: Student have no options in the quiz, so the quiz navigation block is not shown

Login as teacher and go to quiz/view.php page

TEST: No notices/warnings are shown

TEST: Teacher sees all the quiz-own-options on top of the quiz navigation block, after them the standard ones are shown (roles, permissions...)
Show
Debug enabled toDEVELOPER Login as student and go to quiz/view.php page TEST: No notices/warnings are shown TEST: Student have no options in the quiz, so the quiz navigation block is not shown Login as teacher and go to quiz/view.php page TEST: No notices/warnings are shown TEST: Teacher sees all the quiz-own-options on top of the quiz navigation block, after them the standard ones are shown (roles, permissions...)

Was testing some other quiz issues when logged as student I got:

Notice: Undefined offset: 0 in /Users/stronk7/git_moodle/integration/mod/quiz/lib.php on line 1576

It seems that the code introduced by ~~MDL-27908~~ (commit bc502c16) does not handle the situations where there are 0 nodes in the $quiznode.

has been marked as being related by

MDL-27908 Use the facilities of MDL-27600 to improve the quiz settings nav

is duplicated by

MDL-27977 Quiz - Attempting Quiz throws a PHP notice

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie