Moodle
  1. Moodle
  2. MDL-27954

Navigation broken for search in database activity

    Details

    • Testing Instructions:
      Hide

      1. Create a database activity.
      2. In navigation click on "search" under database activity
      3. Search view should come up and not view list.

      Show
      1. Create a database activity. 2. In navigation click on "search" under database activity 3. Search view should come up and not view list.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
      wip-mdl-27954

      Description

      In a database activity, clicking on search (in navigation) shows "view list" and not search. Link needs to be updated with "mode=asearch" currently it's "mode=search"

        Gliffy Diagrams

          Activity

          Hide
          Rossiani Wijaya added a comment -

          Hi Raj,

          The patches are great.

          Just a minor thing, is to upgrade your branch for M20 and possibly rebase the patch for m20.

          Thanks

          Show
          Rossiani Wijaya added a comment - Hi Raj, The patches are great. Just a minor thing, is to upgrade your branch for M20 and possibly rebase the patch for m20. Thanks
          Hide
          Rajesh Taneja added a comment -

          Thanks Rosie
          m20 Rebased

          Show
          Rajesh Taneja added a comment - Thanks Rosie m20 Rebased
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Rajesh Taneja added a comment -

          Rebased all branches.
          Thanks for reminding me Eloy

          Show
          Rajesh Taneja added a comment - Rebased all branches. Thanks for reminding me Eloy
          Hide
          Sam Hemelryk added a comment -

          Thanks Raj, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Raj, this has been integrated now.
          Hide
          Sam Hemelryk added a comment -

          Congratulations - this fix has just been released in the weeklies.

          Show
          Sam Hemelryk added a comment - Congratulations - this fix has just been released in the weeklies.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: