Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27954

Navigation broken for search in database activity

          Details

          • Testing Instructions:
            Hide

            1. Create a database activity.
            2. In navigation click on "search" under database activity
            3. Search view should come up and not view list.

            Show
            1. Create a database activity. 2. In navigation click on "search" under database activity 3. Search view should come up and not view list.
          • Difficulty:
            Easy
          • Affected Branches:
            MOODLE_21_STABLE
          • Fixed Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            wip-mdl-27954
          • Pull Master Diff URL:

            Description

            In a database activity, clicking on search (in navigation) shows "view list" and not search. Link needs to be updated with "mode=asearch" currently it's "mode=search"

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  rwijaya Rossiani Wijaya added a comment -

                  Hi Raj,

                  The patches are great.

                  Just a minor thing, is to upgrade your branch for M20 and possibly rebase the patch for m20.

                  Thanks

                  Show
                  rwijaya Rossiani Wijaya added a comment - Hi Raj, The patches are great. Just a minor thing, is to upgrade your branch for M20 and possibly rebase the patch for m20. Thanks
                  Hide
                  Permalink
                  rajeshtaneja Rajesh Taneja added a comment -

                  Thanks Rosie
                  m20 Rebased

                  Show
                  rajeshtaneja Rajesh Taneja added a comment - Thanks Rosie m20 Rebased
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                  TIA and ciao

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                  Hide
                  Permalink
                  rajeshtaneja Rajesh Taneja added a comment -

                  Rebased all branches.
                  Thanks for reminding me Eloy

                  Show
                  rajeshtaneja Rajesh Taneja added a comment - Rebased all branches. Thanks for reminding me Eloy
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Thanks Raj, this has been integrated now.

                  Show
                  samhemelryk Sam Hemelryk added a comment - Thanks Raj, this has been integrated now.
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Congratulations - this fix has just been released in the weeklies.

                  Show
                  samhemelryk Sam Hemelryk added a comment - Congratulations - this fix has just been released in the weeklies.

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        1/Aug/11