Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27958

Filter: Manage filter page output error

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1
    • Fix Version/s: 2.0.4
    • Component/s: Filters
    • Labels:

      Description

      Coding problem: this page does not set $PAGE->context properly.

      line 341 of /lib/pagelib.php: call to debugging()
      line 599 of /lib/pagelib.php: call to moodle_page->magic_get_context()
      line 1236 of /lib/weblib.php: call to moodle_page->__get()
      line 3581 of /lib/accesslib.php: call to format_string()
      line 52 of /filter/manage.php: call to print_context_name()

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              aborrow Anthony Borrow added a comment -

              I've added Sam as a watcher since he worked on the changes in MDL-23613. Peace - Anthony

              Show
              aborrow Anthony Borrow added a comment - I've added Sam as a watcher since he worked on the changes in MDL-23613 . Peace - Anthony
              Hide
              aborrow Anthony Borrow added a comment -

              so flicked

              Show
              aborrow Anthony Borrow added a comment - so flicked
              Hide
              aborrow Anthony Borrow added a comment -

              I'm linking to the MDLQA-982 but I do not consider MDL-27958 to block it since it does not prevent the behavior but only throws an error

              Show
              aborrow Anthony Borrow added a comment - I'm linking to the MDLQA-982 but I do not consider MDL-27958 to block it since it does not prevent the behavior but only throws an error
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Anthony - had a quick check and is a simple case of adding a set_context call.
              Cheers
              Sam

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Anthony - had a quick check and is a simple case of adding a set_context call. Cheers Sam
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated, thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Passing test without further action. Will be tested by MDLQA-982 once this meets upstream.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Passing test without further action. Will be tested by MDLQA-982 once this meets upstream.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Your awesome code is now part of the next Moodle release, congrats!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Your awesome code is now part of the next Moodle release, congrats!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    1/Aug/11