Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27969

Error when doing random assignment of submissions in Workshop with Moodle 2.1

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 2.0.3, 2.1
    • 2.0.4
    • Workshop
    • MOODLE_20_STABLE, MOODLE_21_STABLE
    • MOODLE_20_STABLE
    • MDL-27969-randomallocator
    • Hide

      Ignore the error message and/or don't type the Save Changes button after allocations are complete. The assignments seem to have been made okay even though this error message is generated.

      Show
      Ignore the error message and/or don't type the Save Changes button after allocations are complete. The assignments seem to have been made okay even though this error message is generated.
    • qa.moodle.net
    • Hide

      See the linked MDLQA. This patch should fix the PHP notices thrown in situations like:

      • manually allocated reviewer without own submission kept during the random allocation that does not include reviewers without the submission
      • removed the student role from a user that is already allocated as a reviewer or reviewee and trying to re-allocate submissions randomly, keeping the current allocations
      Show
      See the linked MDLQA. This patch should fix the PHP notices thrown in situations like: manually allocated reviewer without own submission kept during the random allocation that does not include reviewers without the submission removed the student role from a user that is already allocated as a reviewer or reviewee and trying to re-allocate submissions randomly, keeping the current allocations

    Description

      This issue arose while doing QA Test MDLQA-1041.

      I get the following error message when doing a random assignment of submissions when using the Workshop in Moodle 2.1:

      ( ! ) Notice: Undefined offset: 9 in /html/mod/workshop/allocation/random/lib.php on line 124
      Call Stack

      Time Memory Function Location
      1 0.0002 690544

      {main}( ) ../allocation.php:0
      2 0.1748 41606496 workshop_random_allocator->init( ) ../allocation.php:53

      ( ! ) Notice: Undefined offset: 10 in /html/mod/workshop/allocation/random/lib.php on line 124
      Call Stack
      # Time Memory Function Location
      1 0.0002 690544 {main}

      ( ) ../allocation.php:0
      2 0.1748 41606496 workshop_random_allocator->init( ) ../allocation.php:53
      ( ! ) Notice: Undefined offset: 11 in /html/mod/workshop/allocation/random/lib.php on line 124
      Call Stack

      Time Memory Function Location
      1 0.0002 690544

      {main}

      ( ) ../allocation.php:0
      2 0.1748 41606496 workshop_random_allocator->init( ) ../allocation.php:53

      This occurred when I typed Save Changes after selecting Random allocation. This may be a problem of not understanding exactly what I was supposed to do at this point. Perhaps this was trying to allocate the assessments a second time. This part of the workshop is kind of confusing to me. I would have expected to see a Continue button rather than Save Changes.

      Attachments

        Issue Links

          will help resolve

          Functional Test - A test of a single Moodle feature MDLQA-1041 CLONE - Students can peer-assess in a workshop

          • Passed

          Activity

            People

              mudrd8mz David Mudrák (@mudrd8mz)
              rsturley Steve Turley
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Nobody Nobody
              Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                1/Aug/11