Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29516 DB layer improvements 2.3 META
  3. MDL-27982

UNSIGNED 'support' in XMLDB is a big problem

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1
    • Fix Version/s: 2.3
    • Component/s: Database SQL/XMLDB
    • Labels:
    • Testing Instructions:
      Hide

      1/ install on mysql and postgresql
      2/ upgrade from 2.2 for both mysql and postgresql
      3/ open 3rd party install.xml and do some minor change and save - removal of UNSIGNED attribute expected
      4/ run functional db tests for all supported databases
      5/ compare fresh install and upgraded site - apart from comments it should match

      Show
      1/ install on mysql and postgresql 2/ upgrade from 2.2 for both mysql and postgresql 3/ open 3rd party install.xml and do some minor change and save - removal of UNSIGNED attribute expected 4/ run functional db tests for all supported databases 5/ compare fresh install and upgraded site - apart from comments it should match
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w10_MDL-27982_m23_killunsigned

      Description

      It only works in MySQL, which means it is easy to introduce 'bugs' when working on other databases.

      The general policy is for XMLDB to only expose features that are supported in all our main databases.

      It is not clear what advantage unsigned gives if it is used.

      Therefore, we should remove this from XMLDB.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              timhunt Tim Hunt
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Michael de Raadt
              Participants:
              Component watchers:
              Jake Dallimore, Jun Pataleta
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Jun/12