Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29516 DB layer improvements 2.3 META
  3. MDL-27982

UNSIGNED 'support' in XMLDB is a big problem

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Critical Critical
    • 2.3
    • 2.0.3, 2.1
    • Database SQL/XMLDB
    • MOODLE_20_STABLE, MOODLE_21_STABLE
    • MOODLE_23_STABLE
    • w10_MDL-27982_m23_killunsigned
    • Hide

      1/ install on mysql and postgresql
      2/ upgrade from 2.2 for both mysql and postgresql
      3/ open 3rd party install.xml and do some minor change and save - removal of UNSIGNED attribute expected
      4/ run functional db tests for all supported databases
      5/ compare fresh install and upgraded site - apart from comments it should match

      Show
      1/ install on mysql and postgresql 2/ upgrade from 2.2 for both mysql and postgresql 3/ open 3rd party install.xml and do some minor change and save - removal of UNSIGNED attribute expected 4/ run functional db tests for all supported databases 5/ compare fresh install and upgraded site - apart from comments it should match

      It only works in MySQL, which means it is easy to introduce 'bugs' when working on other databases.

      The general policy is for XMLDB to only expose features that are supported in all our main databases.

      It is not clear what advantage unsigned gives if it is used.

      Therefore, we should remove this from XMLDB.

        1. test_signed.php
          4 kB

            skodak Petr Skoda
            timhunt Tim Hunt
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Michael de Raadt Michael de Raadt
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.