Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27989

mform groups not belonging to a fieldset display badly in core themes whose parent is Canvas

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.0.4, 2.1.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      this issue will be fixed if browsing the attached zip file, each mform element will be well drawn. I added few mform elements to the first release if test.zip in order to evaluate label vertical alignment too.

      Show
      this issue will be fixed if browsing the attached zip file, each mform element will be well drawn. I added few mform elements to the first release if test.zip in order to evaluate label vertical alignment too.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-27989_master

      Description

      by adding a group to a moodleform with $mform->addGroup
      if the group is not contained in a fieldset, its position in the form is strongly on the right in formal_white.

      I am sorry, but I noticed this issue by coding!
      I did not find any other instance in moodle core of this situation so... the only way to test this bug is to add to a moodleform BEFORE an 'header 'a code like:

      $option = array('a label');
                  
      $elementgroup = array();
      $elementgroup[] =& $mform->createElement('select', 'aaa', '', $option);
      $elementgroup[] =& $mform->createElement('text', 'bbb', '');
      $mform->addGroup($elementgroup, 'group', 'one more label', ' ', false);

      and call the modified form from moodle.

        Attachments

          Activity

            People

            Assignee:
            daniss Daniele Cordella
            Reporter:
            daniss Daniele Cordella
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Sam Hemelryk
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              1/Aug/11