Moodle
  1. Moodle
  2. MDL-27998

Canvas standard font size is too small

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.0.4
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      To test, check any core theme that has Canvas theme as a parent (Binarius, Fusion, etc.) confirm that font size looks normal and is not too small.

      Show
      To test, check any core theme that has Canvas theme as a parent (Binarius, Fusion, etc.) confirm that font size looks normal and is not too small.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      17679

      Description

      In 2.1 beta, the canvas theme's default font size has been reduced and is way too small. Since canvas is the parent theme for many other core themes, this problem extends to many other core themes... This is related to this bug fix: http://tracker.moodle.org/browse/MDL-25512 which fixed the placement of the font-size property, but reduced the font size way too much.

        Activity

        Hide
        Michael de Raadt added a comment -

        I've put this on the Stable backlog, but please feel free to work on this as you see fit.

        Michael;

        Show
        Michael de Raadt added a comment - I've put this on the Stable backlog, but please feel free to work on this as you see fit. Michael;
        Hide
        Mary Evans added a comment - - edited

        Hi John,
        The reason the font size was left at 85% is because that was the font-size which was previously set in text.css. It may actually be worth considering taking text.css out all together in Moodle 2.1 and adding it in to the core themes which need it.

        Also related to this fix (see MDL-27704) was the problem with Fusion theme, it might be worth taking another look at that theme after you up the font to 108% in Canvas theme, as the fix I added, that of increasing the following values in Fusion, might, in actual fact, not now be needed, so these values will need to be reversed:

        #page-site-index #region-header {
        /* margin-bottom: 55px; */
        margin-bottom: 65px;

        #region-header

        { /* margin-bottom: 30px; */ margin-bottom: 40px; }

        Mary

        Show
        Mary Evans added a comment - - edited Hi John, The reason the font size was left at 85% is because that was the font-size which was previously set in text.css. It may actually be worth considering taking text.css out all together in Moodle 2.1 and adding it in to the core themes which need it. Also related to this fix (see MDL-27704 ) was the problem with Fusion theme, it might be worth taking another look at that theme after you up the font to 108% in Canvas theme, as the fix I added, that of increasing the following values in Fusion, might, in actual fact, not now be needed, so these values will need to be reversed: #page-site-index #region-header { /* margin-bottom: 55px; */ margin-bottom: 65px; #region-header { /* margin-bottom: 30px; */ margin-bottom: 40px; } Mary
        Hide
        Martin Dougiamas added a comment -

        I see this as pretty urgent ... Moodle text looks very small now ...

        Show
        Martin Dougiamas added a comment - I see this as pretty urgent ... Moodle text looks very small now ...
        Hide
        John Stabinger added a comment -

        The fix is posted up now.

        Mary,

        Fusion looks okay now with the font size fix (and with your other changes still in place). So I don't think it will need a 're-fix'. I agree that text.css probably needs to go at some point and the move of font-size (etc.) to #page in canvas was the right call.

        John

        Show
        John Stabinger added a comment - The fix is posted up now. Mary, Fusion looks okay now with the font size fix (and with your other changes still in place). So I don't think it will need a 're-fix'. I agree that text.css probably needs to go at some point and the move of font-size (etc.) to #page in canvas was the right call. John
        Hide
        Mary Evans added a comment -

        I've just taken a look at the patch you are adding and it looks OK,
        I've set it to 'Waiting for integration review', so hopefully Sam or Eloy will get to see this soon.

        Thanks
        Mary

        Show
        Mary Evans added a comment - I've just taken a look at the patch you are adding and it looks OK, I've set it to 'Waiting for integration review', so hopefully Sam or Eloy will get to see this soon. Thanks Mary
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Just for confirmation... this also affects 20_STABLE that we have rolled a few hours ago.. is it important enough to re-reroll 20_STABLE again today? Or can wait till next Wednesday?

        Show
        Eloy Lafuente (stronk7) added a comment - Just for confirmation... this also affects 20_STABLE that we have rolled a few hours ago.. is it important enough to re-reroll 20_STABLE again today? Or can wait till next Wednesday?
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Also, plz, confirm if it has been already tested, so I can skip that!

        Show
        Eloy Lafuente (stronk7) added a comment - Also, plz, confirm if it has been already tested, so I can skip that!
        Hide
        John Stabinger added a comment -

        I think it is pretty important, as it effects usability across most themes... Whether that is important enough to re-roll 20_STABLE, I can't say...

        Show
        John Stabinger added a comment - I think it is pretty important, as it effects usability across most themes... Whether that is important enough to re-roll 20_STABLE, I can't say...
        Hide
        Eloy Lafuente (stronk7) added a comment -

        oki, 2 notes:

        1) I've cherry picked your commits because there were a mistake in the issue number.
        2) Perhaps it would be interesting, John, to configure your git to have proper fullname and email. I think right now you're the only one not showing that, but "stabijoh". For your consideration.
        3) Being important, I'm going to re-roll 20_STABLE and master NOW. Can I rely 100% the fix is ok? I've tried fusion and seems ok (clearly bigger than before the patch).

        Show
        Eloy Lafuente (stronk7) added a comment - oki, 2 notes: 1) I've cherry picked your commits because there were a mistake in the issue number. 2) Perhaps it would be interesting, John, to configure your git to have proper fullname and email. I think right now you're the only one not showing that, but "stabijoh". For your consideration. 3) Being important, I'm going to re-roll 20_STABLE and master NOW. Can I rely 100% the fix is ok? I've tried fusion and seems ok (clearly bigger than before the patch).
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Tested with Fusion, looks really better now. That and relying into devs are enough to consider this passed.

        Going to re-roll 20_STABLE and master weeklies right now.

        Thanks and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Tested with Fusion, looks really better now. That and relying into devs are enough to consider this passed. Going to re-roll 20_STABLE and master weeklies right now. Thanks and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Done. Now this is in all git & cvs servers. Next packages will also include the fix. So closing.

        Thanks and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Done. Now this is in all git & cvs servers. Next packages will also include the fix. So closing. Thanks and ciao
        Hide
        Mary Evans added a comment -

        Thanks for this Eloy. Sorry I was not about earlier otherwise I would have answered YES it had been tested!

        Cheers
        Mary

        Show
        Mary Evans added a comment - Thanks for this Eloy. Sorry I was not about earlier otherwise I would have answered YES it had been tested! Cheers Mary
        Hide
        Helen Foster added a comment -

        Thanks everyone for fixing this issue. I was thinking I was becoming old and needed glasses, but today found the binarius theme on http://qa.moodle.net/ looking perfect!

        Show
        Helen Foster added a comment - Thanks everyone for fixing this issue. I was thinking I was becoming old and needed glasses, but today found the binarius theme on http://qa.moodle.net/ looking perfect!

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: