Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1
    • Fix Version/s: 2.0.4
    • Component/s: Feedback
    • Labels:
      None
    • Environment:
      php compiled without php5-bcmath
    • Testing Instructions:
      Hide

      create two questions in any feedback. One multichoice and one multichoicerated.
      do some submitts.
      Go to the analysis-page.
      If bcmod() is available so the printed bars are in different colours.
      If bcmod() isn't available so the printed bars are all the same colour.

      Show
      create two questions in any feedback. One multichoice and one multichoicerated. do some submitts. Go to the analysis-page. If bcmod() is available so the printed bars are in different colours. If bcmod() isn't available so the printed bars are all the same colour.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-28014_head

      Description

      There are two calls of bcmod() in item/multichoice/lib.php and item/multichoicerated/lib.php but this function isn't available on each installation.
      Better is to use the % for modulus then bcmod().
      This was just used in a very early time I started php programming .

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Andreas,

            This gets my +1 for integration however we are within the code freeze before 2.1 release now.
            I will talk to Eloy later today if he is happy for it to go it I'm happy to integrate it - otherwise it will have to wait till after the release of 2.1.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Andreas, This gets my +1 for integration however we are within the code freeze before 2.1 release now. I will talk to Eloy later today if he is happy for it to go it I'm happy to integrate it - otherwise it will have to wait till after the release of 2.1. Cheers Sam
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            My +1 to this, seems "innocent" enough to have in integrated.

            Thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - My +1 to this, seems "innocent" enough to have in integrated. Thanks!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Integration achieved

            Show
            samhemelryk Sam Hemelryk added a comment - Integration achieved
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Works Great
            Thanks for providing the fix Andreas.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Works Great Thanks for providing the fix Andreas.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Yay, this is now part of the just released Moodle 2.1 ! Thanks for all the hard work!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Yay, this is now part of the just released Moodle 2.1 ! Thanks for all the hard work!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Aug/11